From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
broonie@kernel.org, srinivas.kandagatla@linaro.org,
jank@cadence.com, slawomir.blauciak@intel.com,
Sanyog Kale <sanyog.r.kale@intel.com>,
Bard liao <yung-chuan.liao@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>
Subject: Re: [alsa-devel] [PATCH 06/14] soundwire: add support for sdw_slave_type
Date: Mon, 4 Nov 2019 08:35:52 -0600 [thread overview]
Message-ID: <d0f4cf88-7799-6176-2336-7bdacbd2b621@linux.intel.com> (raw)
In-Reply-To: <20191103053243.GI2695@vkoul-mobl.Dlink>
On 11/3/19 12:32 AM, Vinod Koul wrote:
> On 23-10-19, 16:28, Pierre-Louis Bossart wrote:
>> Currently the bus does not have any explicit support for master
>> devices. Add explicit support for sdw_slave_type, so that in
>> follow-up patches we can add support for the sdw_md_type (md==Master
>> Device), following the Grey Bus example.
>>
>> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>> ---
>> drivers/soundwire/bus_type.c | 9 ++++++++-
>> drivers/soundwire/slave.c | 7 ++++++-
>> include/linux/soundwire/sdw_type.h | 6 ++++++
>> 3 files changed, 20 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c
>> index 9a0fd3ee1014..5df095f4e12f 100644
>> --- a/drivers/soundwire/bus_type.c
>> +++ b/drivers/soundwire/bus_type.c
>> @@ -49,9 +49,16 @@ int sdw_slave_modalias(const struct sdw_slave *slave, char *buf, size_t size)
>>
>> static int sdw_uevent(struct device *dev, struct kobj_uevent_env *env)
>> {
>> - struct sdw_slave *slave = to_sdw_slave_device(dev);
>> + struct sdw_slave *slave;
>> char modalias[32];
>>
>> + if (is_sdw_slave(dev)) {
>> + slave = to_sdw_slave_device(dev);
>> + } else {
>> + dev_warn(dev, "uevent for unknown Soundwire type\n");
>> + return -EINVAL;
>
> when is the case where this would be triggered?
this is in preparation for the master case, where you will have 2 types
of devices, so need to check if the type is correct.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-11-04 14:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 21:28 [alsa-devel] [PATCH 00/14] soundwire: intel: implement new ASoC interfaces Pierre-Louis Bossart
2019-10-23 21:28 ` [alsa-devel] [PATCH 01/14] soundwire: renames to prepare support for master drivers/devices Pierre-Louis Bossart
2019-10-23 21:28 ` [alsa-devel] [PATCH 02/14] soundwire: rename dev_to_sdw_dev macro Pierre-Louis Bossart
2019-11-03 5:28 ` Vinod Koul
2019-10-23 21:28 ` [alsa-devel] [PATCH 03/14] soundwire: rename drv_to_sdw_slave_driver macro Pierre-Louis Bossart
2019-10-23 21:28 ` [alsa-devel] [PATCH 04/14] soundwire: bus_type: rename sdw_drv_ to sdw_slave_drv Pierre-Louis Bossart
2019-11-03 5:30 ` Vinod Koul
2019-11-04 14:34 ` Pierre-Louis Bossart
2019-10-23 21:28 ` [alsa-devel] [PATCH 05/14] soundwire: intel: rename res field as link_res Pierre-Louis Bossart
2019-10-23 21:28 ` [alsa-devel] [PATCH 06/14] soundwire: add support for sdw_slave_type Pierre-Louis Bossart
2019-11-03 5:32 ` Vinod Koul
2019-11-04 14:35 ` Pierre-Louis Bossart [this message]
2019-11-04 19:33 ` Cezary Rojewski
2019-11-04 19:41 ` Pierre-Louis Bossart
2019-10-23 21:28 ` [alsa-devel] [PATCH 07/14] soundwire: add initial definitions for sdw_master_device Pierre-Louis Bossart
2019-11-03 6:30 ` Vinod Koul
2019-11-04 14:42 ` Pierre-Louis Bossart
2019-11-08 4:04 ` Vinod Koul
2019-11-08 14:41 ` Pierre-Louis Bossart
2019-10-23 21:28 ` [alsa-devel] [PATCH 08/14] soundwire: intel: remove platform devices and provide new interface Pierre-Louis Bossart
2019-10-23 21:28 ` [alsa-devel] [PATCH 09/14] soundwire: add device driver to sdw_md_driver Pierre-Louis Bossart
2019-10-23 21:28 ` [alsa-devel] [PATCH 10/14] soundwire: intel: add prepare support in sdw dai driver Pierre-Louis Bossart
2019-11-04 19:45 ` Cezary Rojewski
2019-11-04 21:31 ` Pierre-Louis Bossart
2019-11-08 4:05 ` Vinod Koul
2019-10-23 21:28 ` [alsa-devel] [PATCH 11/14] soundwire: intel: add trigger " Pierre-Louis Bossart
2019-10-23 21:28 ` [alsa-devel] [PATCH 12/14] soundwire: intel: add sdw_stream_setup helper for .startup callback Pierre-Louis Bossart
2019-10-23 21:28 ` [alsa-devel] [PATCH 13/14] soundwire: intel: free all resources on hw_free() Pierre-Louis Bossart
2019-11-04 20:08 ` Cezary Rojewski
2019-11-04 21:46 ` Pierre-Louis Bossart
2019-11-08 4:14 ` Vinod Koul
2019-11-08 14:39 ` Pierre-Louis Bossart
2019-10-23 21:28 ` [alsa-devel] [PATCH 14/14] soundwire: intel_init: add implementation of sdw_intel_enable_irq() Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0f4cf88-7799-6176-2336-7bdacbd2b621@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=slawomir.blauciak@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).