From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9C5DC10F27 for ; Mon, 9 Mar 2020 17:24:51 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D874208C3 for ; Mon, 9 Mar 2020 17:24:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="t2QqBy2d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D874208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B4949168F; Mon, 9 Mar 2020 18:23:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B4949168F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1583774689; bh=zhXrWZtmsalb6yNy3ZCldrSn9kelCx/Hvo9/Q4Ofooo=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=t2QqBy2dxg6Gmm0KhTJXVaZdwOfBE3etOUPxmxbx90BEsTaHub2xzeJo4mGTt17h4 eF9Wo+O+0Va/OV4MMIK0WkSxjrMbNwMwUGhxq7D9qwbuoOlAVdLavwunU+Cie/M0JL ZEnk3gUwfARc50lfA1Obuq4679SnuY3/EcRct0Fo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3D0E7F8028E; Mon, 9 Mar 2020 18:21:55 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 62587F8028C; Mon, 9 Mar 2020 18:21:52 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B1296F800DA for ; Mon, 9 Mar 2020 18:21:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B1296F800DA X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Mar 2020 10:21:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,534,1574150400"; d="scan'208";a="231003497" Received: from jdbostic-mobl1.amr.corp.intel.com (HELO [10.251.152.35]) ([10.251.152.35]) by orsmga007.jf.intel.com with ESMTP; 09 Mar 2020 10:21:45 -0700 Subject: Re: [PATCH 0/9] ASoC: soc-pcm cleanup step6 To: "Sridharan, Ranjani" , Kuninori Morimoto References: <874kuyi33c.wl-kuninori.morimoto.gx@renesas.com> From: Pierre-Louis Bossart Message-ID: Date: Mon, 9 Mar 2020 12:15:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Linux-ALSA , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Thanks Morimoto-san, >> We are using plural form for for_each_xxx() macro. >> But, for_each_rtd_codec/cpu_dai() are out of this rule. >> 1) - 7) are for it. >> 8) - 9) add new for_each_card_xxx() macros. >> >> Kuninori Morimoto (9): >> 1) ASoC: soc.h: add for_each_rtd_codecs/cpus_dai() macro >> 2) ASoC: Intel: use for_each_rtd_codecs/cpus_dai() macro >> 3) ASoC: mediatek: use for_each_rtd_codecs/cpus_dai() macro >> 4) ASoC: meson: use for_each_rtd_codecs/cpus_dai() macro >> 5) ASoC: qcom: use for_each_rtd_codecs/cpus_dai() macro >> 6) ASoC: soc: use for_each_rtd_codecs/cpus_dai() macro >> 7) ASoC: soc.h: remove non plural form for_each_xxx macro >> 8) ASoC: soc-dapm: add for_each_card_dapms() macro >> 9) ASoC: soc-dapm: add for_each_card_widgets() macro > > LGTM Morimoto-san. I feel like the last 2 patches might be a bit of an > overkill but then they might make sense to keep the code consistent with > the use of the for_each*() macros everywhere. > > Reviewed-by: Ranjani Sridharan LGTM as well. Reviewed-by: Pierre-Louis Bossart