From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8867C32771 for ; Thu, 16 Jan 2020 01:55:04 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76C89222C3 for ; Thu, 16 Jan 2020 01:55:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="p4JrLUOw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76C89222C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A633E17B6; Thu, 16 Jan 2020 02:54:12 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A633E17B6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1579139702; bh=qZuUfo3wAOsnhS8WULV5WMuBajHtk6KXXVS/2tGmtQ4=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=p4JrLUOwaeYxBupCHYKs7xIcpNgPLWoK/Z7S7Lx4tDfLcGwHMVvCGavlYWebTQ9Oa ODBieTVXCD4mTHiUhL9V7VD2TPiXnRbzL9D019w+QeoUF93tkXQ0iy/iY7D/TC11fO uIIhmco1C5UorsHyQmzU561KN+QdjKMAihr05lEM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 93BCCF80228; Thu, 16 Jan 2020 02:53:19 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D8A20F801EB; Thu, 16 Jan 2020 02:53:16 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C385DF800CC for ; Thu, 16 Jan 2020 02:53:13 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C385DF800CC X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2020 17:53:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,324,1574150400"; d="scan'208";a="423839873" Received: from cecox1-mobl.amr.corp.intel.com (HELO [10.251.131.55]) ([10.251.131.55]) by fmsmga005.fm.intel.com with ESMTP; 15 Jan 2020 17:52:54 -0800 To: Bard liao , broonie@kernel.org, tiwai@suse.de References: <20200114175152.3291-1-yung-chuan.liao@linux.intel.com> <20200114175152.3291-3-yung-chuan.liao@linux.intel.com> From: Pierre-Louis Bossart Message-ID: Date: Wed, 15 Jan 2020 19:48:19 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200114175152.3291-3-yung-chuan.liao@linux.intel.com> Content-Language: en-US Cc: liam.r.girdwood@linux.intel.com, alsa-devel@alsa-project.org, bard.liao@intel.com, kuninori.morimoto.gx@renesas.com Subject: Re: [alsa-devel] [PATCH RFC v2 2/4] ASoC: Add multiple CPU DAI support for PCM ops X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > @@ -1810,18 +1972,22 @@ static int dpcm_apply_symmetry(struct snd_pcm_substream *fe_substream, > { > struct snd_soc_dpcm *dpcm; > struct snd_soc_pcm_runtime *fe = fe_substream->private_data; > - struct snd_soc_dai *fe_cpu_dai = fe->cpu_dai; > + struct snd_soc_dai *fe_cpu_dai; > int err; > + int i; > > /* apply symmetry for FE */ > if (soc_pcm_has_symmetry(fe_substream)) > fe_substream->runtime->hw.info |= SNDRV_PCM_INFO_JOINT_DUPLEX; > > /* Symmetry only applies if we've got an active stream. */ > - if (fe_cpu_dai->active) { > - err = soc_pcm_apply_symmetry(fe_substream, fe_cpu_dai); > - if (err < 0) > - return err; > + /* Do we need to support Multi cpu for FE? */ > + for_each_rtd_cpu_dai(fe, i, fe_cpu_dai) { > + if (fe_cpu_dai->active) { > + err = soc_pcm_apply_symmetry(fe_substream, fe_cpu_dai); > + if (err < 0) > + return err; > + } that part seems inconsistent with Patch 4 where you add warnings/error everywhere there's a FE with num_cpus>1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel