From: Sameer Pujar <spujar@nvidia.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org,
Linux-ALSA <alsa-devel@alsa-project.org>,
Stephan Gerhold <stephan@gerhold.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jon Hunter <jonathanh@nvidia.com>,
Mark Brown <broonie@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-tegra <linux-tegra@vger.kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v3 2/3] ASoC: Use schema reference for sound-name-prefix
Date: Tue, 21 Sep 2021 20:45:10 +0530 [thread overview]
Message-ID: <e2d8aede-94b1-2658-a465-5f67795c5725@nvidia.com> (raw)
In-Reply-To: <CAL_JsqJbbDiOAr5-3_JwVMWxdkeGRoPYZuc_8fHp_iGEvH7AWA@mail.gmail.com>
On 9/20/2021 6:27 PM, Rob Herring wrote:
> External email: Use caution opening links or attachments
>
>
> On Fri, Sep 3, 2021 at 11:36 AM Sameer Pujar <spujar@nvidia.com> wrote:
>> Use schema reference for 'sound-name-prefix' property wherever
>> necessary.
>>
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>> Cc: Jerome Brunet <jbrunet@baylibre.com>
>> Cc: Stephan Gerhold <stephan@gerhold.net>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
> [...]
>
>> diff --git a/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml b/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
>> index ffb8fcf..68e5ad2 100644
>> --- a/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
>> +++ b/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
>> @@ -9,6 +9,9 @@ title: NXP/Goodix TFA989X (TFA1) Audio Amplifiers
>> maintainers:
>> - Stephan Gerhold <stephan@gerhold.net>
>>
>> +allOf:
>> + - $ref: name-prefix.yaml#
>> +
>> properties:
>> compatible:
>> enum:
>> @@ -21,12 +24,6 @@ properties:
>> '#sound-dai-cells':
>> const: 0
>>
>> - sound-name-prefix:
> You can't remove the property. This is now a warning in linux-next:
>
> Documentation/devicetree/bindings/sound/nxp,tfa989x.example.dt.yaml:
> audio-codec@34: 'sound-name-prefix' does not match any of the regexes:
> 'pinctrl-[0-9]+'
> From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
> Documentation/devicetree/bindings/sound/nxp,tfa989x.example.dt.yaml:
> audio-codec@36: 'sound-name-prefix' does not match any of the regexes:
> 'pinctrl-[0-9]+'
> From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
>
>
> Just 'sound-name-prefix: true' is fine
I will push a fix for this.
next prev parent reply other threads:[~2021-09-21 15:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 16:35 [PATCH v3 0/3] Convert name-prefix doc to json-schema Sameer Pujar
2021-09-03 16:35 ` [PATCH v3 1/3] ASoC: Add json-schema documentation for sound-name-prefix Sameer Pujar
2021-09-08 11:59 ` Rob Herring
2021-09-03 16:35 ` [PATCH v3 2/3] ASoC: Use schema reference " Sameer Pujar
2021-09-20 12:57 ` Rob Herring
2021-09-21 15:15 ` Sameer Pujar [this message]
2021-09-03 16:35 ` [PATCH v3 3/3] ASoC: Remove name-prefix.txt Sameer Pujar
2021-09-08 11:59 ` Rob Herring
2021-09-13 10:53 ` [PATCH v3 0/3] Convert name-prefix doc to json-schema Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2d8aede-94b1-2658-a465-5f67795c5725@nvidia.com \
--to=spujar@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).