From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Richard Fitzgerald <rf@opensource.cirrus.com>,
broonie@kernel.org, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/7] ARM: dts: Add dts for Raspberry Pi 4 + Cirrus Logic Lochnagar2
Date: Thu, 15 Oct 2020 12:25:49 +0200 [thread overview]
Message-ID: <e9db1a11519dce0938cef867179160a818ec4143.camel@suse.de> (raw)
In-Reply-To: <20201014145418.31838-7-rf@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]
Hi Richard,
your series is very welcome, upstream support for audio codecs on the RPi4 has
always been lackluster.
Could you provide more information on the actual products? Are there custom
made hats for the RPi4 or this wired into a generic development board.
On Wed, 2020-10-14 at 15:54 +0100, Richard Fitzgerald wrote:
> This is based on the default bcm2711-rpi-4-b.dts.
Note that you could've included bcm2711-rpi-4.dts (as if it was a .dtsi).
> Configurations are provided for Cirrus Logic codecs CS42L92, CS47L15,
> CS47L24, CS47L35, CS47L90 and WM8998.
>
> For each codec there is a sound node and a codec device node and both
> default to disabled. Enable the pair for the codec in use.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
> ---
Sadly I don't think creating a new device tree is a good solution here. If we
were to do so for every RPi hat/usage it'd become unmanageable very fast. There
is a way to maintain this in the open nonetheless. I suggest you build a DT
overlay and submit it to https://github.com/raspberrypi/linux, see
'arch/arm/boot/dts/overlays.' The Raspberry Pi engineers have a kernel branch
that tracks of the latest kernel release, so once you get the rest of patches
sorted out and they are included in a release it'll make sense to do so.
I can't tell for other distros, but opensuse packages overlays, so the effort
will ultimately be useful to users.
Regards,
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-10-15 10:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 14:54 [PATCH 0/7] Add dts for Rpi4 + Cirrus Lochnagar and codecs Richard Fitzgerald
2020-10-14 14:54 ` [PATCH 1/7] of: base: Add of_count_phandle_with_fixed_args() Richard Fitzgerald
2020-10-14 18:39 ` Rob Herring
2020-10-15 16:52 ` Robin Murphy
2020-10-16 9:10 ` Richard Fitzgerald
2020-10-16 13:31 ` Rob Herring
2020-10-16 15:14 ` Richard Fitzgerald
2020-10-14 14:54 ` [PATCH 2/7] ASoC: simple-card: Add plls and sysclks DT schema Richard Fitzgerald
2020-10-14 14:54 ` [PATCH 3/7] ASoC: simple-card: Support setting component plls and sysclks Richard Fitzgerald
2020-10-14 14:54 ` [PATCH 4/7] ASoC: arizona: Allow codecs to be selected from kernel config Richard Fitzgerald
2020-10-15 0:19 ` kernel test robot
2020-10-14 14:54 ` [PATCH 5/7] ASoC: madera: " Richard Fitzgerald
2020-10-14 14:54 ` [PATCH 6/7] ARM: dts: Add dts for Raspberry Pi 4 + Cirrus Logic Lochnagar2 Richard Fitzgerald
2020-10-15 10:25 ` Nicolas Saenz Julienne [this message]
2020-10-15 11:14 ` Richard Fitzgerald
2020-10-15 15:12 ` Nicolas Saenz Julienne
2020-10-15 17:32 ` Mark Brown
2020-10-16 9:01 ` Richard Fitzgerald
2020-10-14 14:54 ` [PATCH 7/7] MAINTAINERS: Add dts for Cirrus Logic Lochnagar on RPi4 Richard Fitzgerald
2020-10-14 18:56 ` [PATCH 0/7] Add dts for Rpi4 + Cirrus Lochnagar and codecs Mark Brown
2020-10-16 13:30 ` Richard Fitzgerald
2020-10-16 15:18 ` Mark Brown
2020-10-19 20:48 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9db1a11519dce0938cef867179160a818ec4143.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).