From: "Liao, Bard" <bard.liao@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Bard liao <yung-chuan.liao@linux.intel.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"tiwai@suse.de" <tiwai@suse.de>
Cc: "liam.r.girdwood@linux.intel.com"
<liam.r.girdwood@linux.intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"kuninori.morimoto.gx@renesas.com"
<kuninori.morimoto.gx@renesas.com>
Subject: Re: [alsa-devel] [PATCH RFC v2 2/4] ASoC: Add multiple CPU DAI support for PCM ops
Date: Thu, 16 Jan 2020 02:05:41 +0000 [thread overview]
Message-ID: <eb5f5e4115a14c46bccd034f1127a5a3@intel.com> (raw)
In-Reply-To: <dc9075b8-7418-e910-47cd-eb181a4d9028@linux.intel.com>
> -----Original Message-----
> From: Pierre-Louis Bossart [mailto:pierre-louis.bossart@linux.intel.com]
> Sent: Thursday, January 16, 2020 9:48 AM
> To: Bard liao <yung-chuan.liao@linux.intel.com>; broonie@kernel.org;
> tiwai@suse.de
> Cc: alsa-devel@alsa-project.org; liam.r.girdwood@linux.intel.com;
> kuninori.morimoto.gx@renesas.com; Liao, Bard <bard.liao@intel.com>
> Subject: Re: [alsa-devel] [PATCH RFC v2 2/4] ASoC: Add multiple CPU DAI
> support for PCM ops
>
>
> > @@ -1810,18 +1972,22 @@ static int dpcm_apply_symmetry(struct
> snd_pcm_substream *fe_substream,
> > {
> > struct snd_soc_dpcm *dpcm;
> > struct snd_soc_pcm_runtime *fe = fe_substream->private_data;
> > - struct snd_soc_dai *fe_cpu_dai = fe->cpu_dai;
> > + struct snd_soc_dai *fe_cpu_dai;
> > int err;
> > + int i;
> >
> > /* apply symmetry for FE */
> > if (soc_pcm_has_symmetry(fe_substream))
> > fe_substream->runtime->hw.info |=
> SNDRV_PCM_INFO_JOINT_DUPLEX;
> >
> > /* Symmetry only applies if we've got an active stream. */
> > - if (fe_cpu_dai->active) {
> > - err = soc_pcm_apply_symmetry(fe_substream, fe_cpu_dai);
> > - if (err < 0)
> > - return err;
> > + /* Do we need to support Multi cpu for FE? */
> > + for_each_rtd_cpu_dai(fe, i, fe_cpu_dai) {
> > + if (fe_cpu_dai->active) {
> > + err = soc_pcm_apply_symmetry(fe_substream,
> fe_cpu_dai);
> > + if (err < 0)
> > + return err;
> > + }
>
> that part seems inconsistent with Patch 4 where you add warnings/error
> everywhere there's a FE with num_cpus>1
Actually, I have a question here. Do we need to support Multi cpu for FE?
If yes, what is the use case?
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-01-16 2:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 17:51 [alsa-devel] [PATCH RFC v2 0/4] ASoC: Add Multi CPU DAI support Bard liao
2020-01-14 17:51 ` [alsa-devel] [PATCH RFC v2 1/4] ASoC: Add initial support for multiple CPU DAIs Bard liao
2020-01-14 17:51 ` [alsa-devel] [PATCH RFC v2 2/4] ASoC: Add multiple CPU DAI support for PCM ops Bard liao
2020-01-16 1:48 ` Pierre-Louis Bossart
2020-01-16 2:05 ` Liao, Bard [this message]
2020-01-16 2:25 ` Pierre-Louis Bossart
2020-01-14 17:51 ` [alsa-devel] [PATCH RFC v2 3/4] ASoC: Add multiple CPU DAI support in DAPM Bard liao
2020-01-14 17:51 ` [alsa-devel] [PATCH RFC v2 4/4] ASoC: add warning if the function is not support multi cpu yet Bard liao
2020-01-16 1:49 ` Pierre-Louis Bossart
2020-01-16 7:42 ` Liao, Bard
2020-01-17 0:45 ` Kuninori Morimoto
2020-01-15 6:11 ` [alsa-devel] [PATCH RFC v2 0/4] ASoC: Add Multi CPU DAI support Kuninori Morimoto
2020-01-15 22:13 ` Pierre-Louis Bossart
2020-01-16 0:47 ` Kuninori Morimoto
2020-01-16 1:20 ` Pierre-Louis Bossart
2020-01-16 1:52 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb5f5e4115a14c46bccd034f1127a5a3@intel.com \
--to=bard.liao@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).