From: Roy Spliet <nouveau@spliet.org>
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: Re: [PATCH 4/6] ALSA: hda: Keep the controller initialization even if no codecs found
Date: Mon, 13 Apr 2020 11:52:55 +0100 [thread overview]
Message-ID: <ec79a499-3b55-3bea-13ff-9e3802d6b092@spliet.org> (raw)
In-Reply-To: <20200413082034.25166-5-tiwai@suse.de>
Op 13-04-2020 om 09:20 schreef Takashi Iwai:
> Currently, when the HD-audio controller driver doesn't detect any
> codecs, it tries to abort the probe. But this abort happens at the
> delayed probe, i.e. the primary probe call already returned success,
> hence the driver is never unbound until user does so explicitly.
> As a result, it may leave the HD-audio device in the running state
> without the runtime PM. More badly, if the device is a HD-audio bus
> that is tied with a GPU, GPU cannot reach to the full power down and
> consumes unnecessarily much power.
>
> This patch changes the logic after no-codec situation; it continues
> probing without the further codec initialization but keep the
> controller driver running normally.
>
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207043
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Tested-by: Roy Spliet <nouveau@spliet.org>
> ---
> sound/pci/hda/hda_intel.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 692857904d49..aa0be85614b6 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2009,7 +2009,7 @@ static int azx_first_init(struct azx *chip)
> /* codec detection */
> if (!azx_bus(chip)->codec_mask) {
> dev_err(card->dev, "no codecs found!\n");
> - return -ENODEV;
> + /* keep running the rest for the runtime PM */
> }
>
> if (azx_acquire_irq(chip, 0) < 0)
> @@ -2303,9 +2303,11 @@ static int azx_probe_continue(struct azx *chip)
> #endif
>
> /* create codec instances */
> - err = azx_probe_codecs(chip, azx_max_codecs[chip->driver_type]);
> - if (err < 0)
> - goto out_free;
> + if (bus->codec_mask) {
> + err = azx_probe_codecs(chip, azx_max_codecs[chip->driver_type]);
> + if (err < 0)
> + goto out_free;
> + }
>
> #ifdef CONFIG_SND_HDA_PATCH_LOADER
> if (chip->fw) {
> @@ -2319,7 +2321,7 @@ static int azx_probe_continue(struct azx *chip)
> #endif
> }
> #endif
> - if ((probe_only[dev] & 1) == 0) {
> + if (bus->codec_mask && !(probe_only[dev] & 1)) {
> err = azx_codec_configure(chip);
> if (err < 0)
> goto out_free;
>
next prev parent reply other threads:[~2020-04-14 7:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 8:20 [PATCH 0/6] ALSA: hda: Fix/improve no-codec bus Takashi Iwai
2020-04-13 8:20 ` [PATCH 1/6] ALSA: hda: Don't release card at firmware loading error Takashi Iwai
2020-04-13 8:20 ` [PATCH 2/6] ALSA: hda: Honor PM disablement in PM freeze and thaw_noirq ops Takashi Iwai
2020-04-13 8:20 ` [PATCH 3/6] ALSA: hda: Release resources at error in delayed probe Takashi Iwai
2020-04-13 8:20 ` [PATCH 4/6] ALSA: hda: Keep the controller initialization even if no codecs found Takashi Iwai
2020-04-13 10:52 ` Roy Spliet [this message]
2020-04-13 8:20 ` [PATCH 5/6] ALSA: hda: Skip controller resume if not needed Takashi Iwai
2020-04-13 8:20 ` [PATCH 6/6] ALSA: hda: Explicitly permit using autosuspend if runtime PM is supported Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec79a499-3b55-3bea-13ff-9e3802d6b092@spliet.org \
--to=nouveau@spliet.org \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).