From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ABC8C433E0 for ; Thu, 30 Jul 2020 15:29:06 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16C0E20838 for ; Thu, 30 Jul 2020 15:29:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Pl2BydGs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16C0E20838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8003A17AA; Thu, 30 Jul 2020 17:28:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8003A17AA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1596122944; bh=wkq/sAfUmmrdd/XPQ1DEDfQ5wKNbUVjPOJVpCgYZvJk=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Pl2BydGs7wdttF5BwME5JugCCUs3elUalIXztohfmxspiX3pCKwG76rPxCejPPZRX +G4LHvmGrBVdwRg+MUpkETduDf2PsUdxBdDh33ElXJcE1K7fbh4iAhclBaWZG8PnzH A6MA4dRbxwP2f52wCFmEkr6+xPTDaSpOCVfXNqOc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2453DF800C9; Thu, 30 Jul 2020 17:28:14 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 61D66F8021E; Thu, 30 Jul 2020 17:28:12 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 49284F80111 for ; Thu, 30 Jul 2020 17:28:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 49284F80111 IronPort-SDR: d8ON4v+NpkJ15a59UwWW8Z3shgx9AqivRUj2fGdqFVNc32uQ+cpRZuDbihU5ex/UtToPadTnbl ApgrIA2DY6Zg== X-IronPort-AV: E=McAfee;i="6000,8403,9698"; a="152842526" X-IronPort-AV: E=Sophos;i="5.75,414,1589266800"; d="scan'208";a="152842526" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2020 08:28:02 -0700 IronPort-SDR: gewmfRNTI+SQO76RR3vjSFXBpP2tQjoa0VuEZUc8PtYAj7exldhN0NOurCY5ZTcz5eot/dVMed 2aRhA6jnzNSw== X-IronPort-AV: E=Sophos;i="5.75,414,1589266800"; d="scan'208";a="465279278" Received: from jrwang2-mobl.amr.corp.intel.com (HELO [10.212.82.25]) ([10.212.82.25]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2020 08:27:59 -0700 Subject: Re: [PATCH 2/2] ASoC: Intel: Add period size constraint on strago board To: "Lu, Brent" , "alsa-devel@alsa-project.org" References: <1596020585-11517-1-git-send-email-brent.lu@intel.com> <1596020585-11517-3-git-send-email-brent.lu@intel.com> <4fe97f63-e552-3b2f-803c-53894b196bfd@linux.intel.com> From: Pierre-Louis Bossart Message-ID: Date: Thu, 30 Jul 2020 10:27:58 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Guennadi Liakhovetski , "Rojewski, Cezary" , Kai Vehmanen , Kuninori Morimoto , Jie Yang , Takashi Iwai , "linux-kernel@vger.kernel.org" , Liam Girdwood , Sam McNally , Mark Brown , Ranjani Sridharan , Daniel Stuart , Andy Shevchenko , Yu-Hsuan Hsu , Damian van Soelen X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >> Is this patch required if you've already constrained the period sizes for the >> platform driver in patch1? > > Yes or alsa will select 320 as default period size for it. ok, then that's a miss in your patch1. 320 samples is a multiple of 1ms for 48kHz rates. I think it was valid only for the 16kHz VoIP paths used in some versions of Android, but that we don't support in the upstream code. To build on Takashi's answer, the real ask here is to require that the period be a multiple of 1ms, because that's the fundamental design/limitation of firmware. It doesn't matter if it's 48, 96, 192, 240, 480, 960 samples.