From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D18C6C433DB for ; Wed, 20 Jan 2021 05:08:02 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E6FB62311C for ; Wed, 20 Jan 2021 05:08:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6FB62311C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4F8251899; Wed, 20 Jan 2021 06:07:07 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4F8251899 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1611119277; bh=AFnIeKG3uVl+iY6U/2mo+oJ44nJ9fa8RMu5UEyTd2T0=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=g8GpTVqoF6KjM8bwfhV6FcTolPgzGpzEmbS2cMG9lp4NvRyjhPinVhm037ONFN6Ed 6idCU+1Tn3AqKV0MTeeQ2l22lbhNB6wCP8oQ8Q8IA2GvH9ufSlts2z8B/2kho6Kqqa FX4BoGEa6WirwsKQHc8nvZKdb/JVSepjr67RFNVM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CE1FFF80166; Wed, 20 Jan 2021 06:07:06 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3BBB5F8016E; Wed, 20 Jan 2021 06:07:06 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 74F8FF80137 for ; Wed, 20 Jan 2021 06:06:58 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 74F8FF80137 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="iqJqehfr" Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 19 Jan 2021 21:06:54 -0800 Received: from [10.25.99.10] (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 20 Jan 2021 05:06:48 +0000 Subject: Re: Re: Re: [RESEND PATCH v6 5/6] arm64: tegra: Audio graph header for Tegra210 To: Thierry Reding References: <1611048496-24650-1-git-send-email-spujar@nvidia.com> <1611048496-24650-6-git-send-email-spujar@nvidia.com>

From: Sameer Pujar Message-ID: Date: Wed, 20 Jan 2021 10:36:44 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1611119214; bh=TrUW/bRVd0y6RBunmo1Nvw8U/CisQ85mSiTQB96uz4Q=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding: Content-Language:X-Originating-IP:X-ClientProxiedBy; b=iqJqehfrlGaLEYWRtxL8pSQcX78r9QttWiB+MThCuJIKgzBAG05ePIeO7kEtH3u/w lKt3gIrqHKl2y2rosb6wvtl0mGOf4xTMhixn97FdZEXDfyp1TXk1MBmpz4dGKFTh0p 6yuyUPjOwC1fWbInmd2GX5IlkNh0bscT1c4rJ7bz5rkxVsv8a+y8jLOEHjV27Dw+Np CXv7nlVgSuim4YEU3v93drYtjTu4UdfUo66xQPY/+Vh21xrI9i/319L0kc1ub4RLYK XuVuyONSrYrmMpaopjtSGaxQSv2E0F8WFn/+psAoaISZ87LPRUOIIH62rj+IqyrO3i lYpd9Yh5WOaEg== Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, jonathanh@nvidia.com, sharadg@nvidia.com, broonie@kernel.org, linux-tegra@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 1/19/2021 11:27 PM, Thierry Reding wrote: > On Tue, Jan 19, 2021 at 11:09:32PM +0530, Sameer Pujar wrote: >> >> On 1/19/2021 10:45 PM, Thierry Reding wrote: >>> On Tue, Jan 19, 2021 at 02:58:15PM +0530, Sameer Pujar wrote: >>>> Expose a header which describes DT bindings required to use audio-graph >>>> based sound card. All Tegra210 based platforms can include this header >>>> and add platform specific information. Currently, from SoC point of view, >>>> all links are exposed for ADMAIF, AHUB, I2S and DMIC components. >>>> >>>> Signed-off-by: Sameer Pujar >>>> Reviewed-by: Jon Hunter >>>> --- >>>> .../boot/dts/nvidia/tegra210-audio-graph.dtsi | 153 +++++++++++++++++++++ >>>> 1 file changed, 153 insertions(+) >>>> create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-audio-graph.dtsi >>> I prefer keeping everything in tegra210.dtsi, but I can do that merge >>> when I apply, after the DT bindings have been acked, so no need to >>> resend just because of that. >> I think this may be fine for Tegra210 based boards. But for Tegra186 and >> Tegra194, whenever we add support for it, can rely on a common audio-graph >> dtsi because there is no change w.r.t APE. This can help us to avoid >> duplication of the bindings. This most likely applies to future chips as >> well (where Tegra186 audio-graph bindings can be considered as base) when >> there is no significant change in APE. > Maybe. Although that argument is somewhat extreme because we already > have some of that same duplication throughout the other .dtsi files. By > the same argument we could save a bit of duplication by having something > like tegra-gpio.dtsi and including that in all the SoC .dtsi files and > only update the compatible string, because that's the only significant > change. > Duplication isn't a big problem for DTS files because the data is meant > to be stable anyway. So once it is in place and doesn't have to change, > it really doesn't matter if it comes from an include or it's duplicated. OK, if there is no issue with duplication then fine with me. Thanks.