* Re: [PATCH] ALSA: usx2y: Prefer struct_size over open coded arithmetic
[not found] <20210919133727.44694-1-len.baker@gmx.com>
@ 2021-09-21 16:41 ` Takashi Iwai
0 siblings, 0 replies; only message in thread
From: Takashi Iwai @ 2021-09-21 16:41 UTC (permalink / raw)
To: Len Baker
Cc: alsa-devel, Kees Cook, linux-kernel, Gustavo A. R. Silva,
Takashi Iwai, linux-hardening, gushengxian
On Sun, 19 Sep 2021 15:37:27 +0200,
Len Baker wrote:
>
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
>
> In this case this is not actually dynamic size: all the operands
> involved in the calculation are constant values. However it is better to
> refactor this anyway, just to keep the open-coded math idiom out of
> code.
>
> So, use the struct_size() helper to do the arithmetic instead of the
> argument "size + size * count" in the kzalloc() function.
>
> Also, take the opportunity to refactor the declaration variables to make
> it more easy to read.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
>
> Signed-off-by: Len Baker <len.baker@gmx.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-09-21 16:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210919133727.44694-1-len.baker@gmx.com>
2021-09-21 16:41 ` [PATCH] ALSA: usx2y: Prefer struct_size over open coded arithmetic Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).