alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Hui Wang <hui.wang@canonical.com>
Cc: alsa-devel@alsa-project.org, kai.vehmanen@linux.intel.com
Subject: Re: [RFC][PATCH v4 3/4] alsa: jack: add more jack_kctl debugfs nodes
Date: Wed, 20 Jan 2021 15:58:02 +0100	[thread overview]
Message-ID: <s5h35yvejut.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210111130557.90208-4-hui.wang@canonical.com>

On Mon, 11 Jan 2021 14:05:56 +0100,
Hui Wang wrote:
> 
> Adding 4 more debugfs nodes, users could get more information about
> the jack_kctl from them:
>  - kctl_id, read-only, get jack_kctl->kctl's id
>    sound/card0/HeadphoneJack# cat kctl_id
>    Headphone Jack
> 
>  - mask_bits, read-only, get jack_kctl's events mask_bits
>    sound/card0/HeadphoneJack# cat mask_bits
>    0x0001 HEADPHONE(0x0001)
> 
>  - status, read-only, get jack_kctl's current status
>    headphone unplugged:
>    sound/card0/HeadphoneJack# cat status
>    0x0000
>    headphone plugged:
>    sound/card0/HeadphoneJack# cat status
>    0x0001 HEADPHONE(0x0001)
> 
>  - type, read-only, get jack's supported events type
>    sound/card0/HeadphoneJack# cat type
>    0x0001 HEADPHONE(0x0001)

I believe we should have a proper documentation in Documentation/ to
describe all those.

And the debugfs callbacks could be optimized without malloc as I
mentioned in another mail, too.


thanks,

Takashi

  reply	other threads:[~2021-01-20 14:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11 13:05 [RFC][PATCH v4 0/4] design a way to change audio Jack state by software Hui Wang
2021-01-11 13:05 ` [RFC][PATCH v4 1/4] alsa: jack: implement software jack injection via debugfs Hui Wang
2021-01-20 14:51   ` Takashi Iwai
2021-01-11 13:05 ` [RFC][PATCH v4 2/4] alsa: jack: adjust jack_kctl debugfs folder's name Hui Wang
2021-01-20 14:55   ` Takashi Iwai
2021-01-11 13:05 ` [RFC][PATCH v4 3/4] alsa: jack: add more jack_kctl debugfs nodes Hui Wang
2021-01-20 14:58   ` Takashi Iwai [this message]
2021-01-11 13:05 ` [RFC][PATCH v4 4/4] alsa: jack: implement save-and-restore for jack's hw status Hui Wang
2021-01-20  8:58 ` [RFC][PATCH v4 0/4] design a way to change audio Jack state by software Hui Wang
2021-01-20 14:47   ` Takashi Iwai
2021-01-21 12:48     ` Hui Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h35yvejut.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=hui.wang@canonical.com \
    --cc=kai.vehmanen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).