From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 519F1C433E0 for ; Wed, 20 Jan 2021 14:48:19 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2482F23382 for ; Wed, 20 Jan 2021 14:48:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2482F23382 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 184B317BD; Wed, 20 Jan 2021 15:47:25 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 184B317BD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1611154095; bh=MvTN6MgR+vWLP+6h1hEORAiYeKiiOqak2TK4MiOdR9w=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=a+u0A3Lt+RNwG1sIA6m1uzCt7pNOsqeP97I9jXRv1/XLv2lJ373JqYhjmDtVtT3RA DstXFDFGIfgjiulNoQfHh0GFq/Y0DjuV1xSJmBlbe84UOL+xUsdPVPk9ynoijk2X6D MrA/nnjnQCuf2mu/wwMY9pDHRe6KLZBiyUg+cPQ0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9CF7EF8012C; Wed, 20 Jan 2021 15:47:24 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A4C10F8016E; Wed, 20 Jan 2021 15:47:23 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3D7FCF8012C for ; Wed, 20 Jan 2021 15:47:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3D7FCF8012C X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 74E74AB7F; Wed, 20 Jan 2021 14:47:19 +0000 (UTC) Date: Wed, 20 Jan 2021 15:47:19 +0100 Message-ID: From: Takashi Iwai To: Hui Wang Subject: Re: [RFC][PATCH v4 0/4] design a way to change audio Jack state by software In-Reply-To: References: <20210111130557.90208-1-hui.wang@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, kai.vehmanen@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 20 Jan 2021 09:58:25 +0100, Hui Wang wrote: > > Hi Takashi, > > Looks like no more comment from others, what is your opinion on the > patchset, is it ok to merge or need to do some change? I think the basic concept is OK. Maybe we want to have a Kconfig to enable/disable this feature for users who want a slim kernel. And, it'd be better to reorganize the series. It's not necessarily incremental form; e.g. patch 2 doesn't have to be an individual patch. I'll take a deeper look for each patch, too. thanks, Takashi > > Thanks, > > Hui. > > On 1/11/21 9:05 PM, Hui Wang wrote: > > the changes in the v4: > > - change the sound-core to sound and change the sound_core_debugfs_root > > to sound_debugfs_root in the 0001-xxx.patch > > - change kzalloc/kfree to kvzalloc/kvfree in the debugfs fops for > > 0001-xxx.patch and 0003-xxx.patch > > - And if needed, I could squash 4 patches into 1 patch before merging. > > > > the changes in the v3 (for easy to review, divide change into 4 patches): > > - address the comment about the snd_jack_report() and _snd_jack_report(), > > the v2 design is hard to understand and is hard to review, in the v3, > > separate the jack_report to snd_jack_report() and snd_jack_inject_report(), > > hw jack events call snd_jack_report() as before, if a jack contains multi > > jack_kctl and the jack_kctl's sw_inject is enabled, the status and the > > related input-dev's events will not be reproted. The injection events call > > snd_jack_inject_report(). This change is squashed to 0001-xxx.patch, the > > rest part of 0001-xxx.patch is same as v2. > > > > - address the comment about folders'name in the 0002-xxx.patch, so far, drop > > the '/', ',', '=' and ' ' from the folders' name. > > > > - address the comment about adding more debugfs nodes in the 0003-xxx.patch, > > it adds kctl_id, mask_bits, status and type. > > > > - address the comment about save-n-restore jack's hw status in the > > 0004-xxx.patch, adding a hw_status_cache and save the last reported jack > > hw event, once the sw_inject is disabled, will restore all jack_kctl's > > state under the same snd_jack with hw_status_cache. > > [snip] > > > > > > the changes in the V2: > > - using debugfs instead of sysfs > > - using jack_ctrl to create a folder instead of snd_jack, since ASoC drivers > > could create multi jack_ctrls within a snd_jack > > - create a folder for each jack_ctrl instead for all jack_ctrls > > [ snip ] > > > > > > Hui Wang (4): > > alsa: jack: implement software jack injection via debugfs > > alsa: jack: adjust jack_kctl debugfs folder's name > > alsa: jack: add more jack_kctl debugfs nodes > > alsa: jack: implement save-and-restore for jack's hw status > > > > include/sound/core.h | 2 + > > include/sound/jack.h | 1 + > > sound/core/init.c | 7 + > > sound/core/jack.c | 352 ++++++++++++++++++++++++++++++++++++++++++- > > sound/core/sound.c | 8 + > > 5 files changed, 366 insertions(+), 4 deletions(-) > > >