From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7EDAC432C3 for ; Fri, 15 Nov 2019 13:22:47 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 241D3206D9 for ; Fri, 15 Nov 2019 13:22:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="LfUlVw6z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 241D3206D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 295C51615; Fri, 15 Nov 2019 14:21:55 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 295C51615 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1573824165; bh=7qxYp+U4N7undCAr/YgykTcb33CC6A86VdA7gr/2Vrc=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LfUlVw6z9TZ7wjpOpsRqJLE1gM4jrBR0y2EQLn/CQ4sz1wYYQCM7AreMQlvAA9VDi JqGyCvROXsZSnUyfGA6WByoVnGwjwKiwR4t1wFC7Exdq2l0ZP9zL7UWOkQANfUz/+j mzut1LfG68boWq/cb3h1IP93zXc0WpU6sj4ngp+4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AD6BDF80103; Fri, 15 Nov 2019 14:21:54 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 97457F80106; Fri, 15 Nov 2019 14:21:53 +0100 (CET) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 75489F800FF for ; Fri, 15 Nov 2019 14:21:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 75489F800FF X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id F21EBABF6; Fri, 15 Nov 2019 13:21:50 +0000 (UTC) Date: Fri, 15 Nov 2019 14:21:50 +0100 Message-ID: From: Takashi Iwai To: Vinod Koul In-Reply-To: <20191115102705.649976-1-vkoul@kernel.org> References: <20191115102705.649976-1-vkoul@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: Pierre-Louis Bossart , alsa-devel@alsa-project.org, Banajit Goswami , Liam Girdwood , linux-arm-msm@vger.kernel.org, Patrick Lai , Takashi Iwai , Mark Brown , Bjorn Andersson , linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [RFC PATCH 0/3] ALSA: compress: Add support for FLAC X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 15 Nov 2019 11:27:02 +0100, Vinod Koul wrote: > > The current design of sending codec parameters assumes that decoders > will have parsers so they can parse the encoded stream for parameters > and configure the decoder. > > But this assumption may not be universally true and we know some DSPs > which do not contain the parsers so additional parameters are required > to be passed. > > So add these parameters starting with FLAC decoder. The size of > snd_codec_options is still 120 bytes after this change (due to this > being a union) > > I think we should also bump the (minor) version if this proposal is > acceptable so the userspace can check and populate flac specific structure. > > Along, with the core header change, patches are added to support FLAC > in Qualcomm drivers. This was tested on 96boards db845c > > Srinivas Kandagatla (1): > ASoC: qcom: q6asm: add support to flac config > > Vinod Koul (2): > ALSA: compress: add flac decoder params > ASoC: qcom: q6asm-dai: add support to flac decoder Feel free to take my ACK for ALSA core part: Acked-by: Takashi Iwai thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel