From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07D29C433DB for ; Sun, 3 Jan 2021 17:20:32 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B55720658 for ; Sun, 3 Jan 2021 17:20:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B55720658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4D4BC15E4; Sun, 3 Jan 2021 18:19:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4D4BC15E4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1609694428; bh=H5CSa8Bww10XhnOMvawuqiLvp+3ga0vn3w/rojEmcRU=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=KTaHTZpcB9ktjIvJ1EL9ZGRMVKENMulksLV/9u6dGQ4k+qAeH3D6R/T5lRzNyfZsg dRA7yTqoE0xMy2bSFv+hu/0F3tpcg484YY9PNVBwNASmeW/2aZ78aVOFZsCNtxkIPW 3yLCZuNBUbJDEav3/7b8tylqwkDCdtUYHhqDBoj4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D3BD9F801F5; Sun, 3 Jan 2021 18:19:37 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 671F2F80268; Sun, 3 Jan 2021 18:19:34 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E0BC2F8014C for ; Sun, 3 Jan 2021 18:19:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E0BC2F8014C X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D71E8AE1C; Sun, 3 Jan 2021 17:19:30 +0000 (UTC) Date: Sun, 03 Jan 2021 18:19:30 +0100 Message-ID: From: Takashi Iwai To: =?UTF-8?B?RnJhbnRpxaFlayBLdcSNZXJh?= Subject: Re: [PATCH 14/41] ALSA: usb-audio: Create endpoint objects at parsing phase - Pioneer DJ DJM-250MK2 stopped working In-Reply-To: References: <20201123085347.19667-1-tiwai@suse.de> <20201123085347.19667-15-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: alsa-devel@alsa-project.org, Matwey Kornilov , Dylan Robinson , Keith Milner X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, 03 Jan 2021 18:09:41 +0100, František Kučera wrote: > > Dne 23. 11. 20 v 9:53 Takashi Iwai napsal(a): > > Currently snd_usb_endpoint objects are created at first when the > > substream is opened and tries to assign the endpoints corresponding to > > the matching audioformat. But since basically the all endpoints have > > been already parsed and the information have been obtained, we may > > create the endpoint objects statically at the init phase. It's easier > > to manage for the implicit fb case, for example. > > > > This patch changes the endpoint object management and lets the parser > > to create the all endpoint objects. > > > > This change shouldn't bring any functional changes. > > The Pioneer DJ DJM-250MK2 (implemented in 73d8c9408434, 14335d8b9e1a, cdc01a1558de) stopped working. > > After bisecting, it seems that it worked in 5fd255f4fe97 and stopped working in 54cb31901b83. > > The arecord says: set_params:1407: Unable to install hw params > > And even playback is impossible in this version. But there is no error in the log. However in later versions (e.g. eda809aef534) I found errors in kern.log: > > usb 1-3: Cannot find EP 0x1 to open > > usb 1-3: Cannot find EP 0x82 to open > > (each repeats 20 or more times, seems to be in pcm.c in subs->data_endpoint = snd_usb_endpoint_open(chip, fmt, hw_params, false);) > > Could you please check it? I am not sure whether it should be fixed in the DJM-250MK2 specific code or here. Could you give lsusb -v output as well as /proc/asound/card*/usbmixer and stream* files? The proc files are at best from both older and new kernels. thanks, Takashi