Alsa-Devel Archive on
 help / color / Atom feed
From: Takashi Iwai <>
To: Chris Wilson <>
Cc: Jonas Witschel <>,
Subject: Re: [alsa-devel] [PATCH] Revert "ALSA: hda: Flush interrupts on disabling"
Date: Mon, 28 Oct 2019 09:24:00 +0100
Message-ID: <> (raw)
In-Reply-To: <157225086749.26808.5121664839140883561@skylake-alporthouse-com>

On Mon, 28 Oct 2019 09:21:07 +0100,
Chris Wilson wrote:
> Quoting Takashi Iwai (2019-10-28 08:10:56)
> > This reverts commit caa8422d01e983782548648e125fd617cadcec3f.
> > 
> > It turned out that this commit caused a regression at shutdown /
> > reboot, as the synchronize_irq() calls seems blocking the whole
> > shutdown.  Also another part of the change about shuffling the call
> > order looks suspicious; the azx_stop_chip() call disables the CORB /
> > RIRB while the others may still need the CORB/RIRB update.
> > 
> > Since the original commit itself was a cargo-fix, let's revert the
> > whole patch.
> You will want to include a link to the bug you may be reintroducing so
> you have that information for easy reference later.

Actually I forgot to put the Fixes tag where usually you can track the
original issue from there.  Will fix it.  I don't mind to put yet
another bug link tag, though.

> Also do you know if you fixed the bug in any other way, because our CI
> hasn't reported that GPF since the patch landed.

Well, let's see whether the GPF reappears with the revert at first.
It might be another fix that covered.


Alsa-devel mailing list

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28  8:10 Takashi Iwai
2019-10-28  8:21 ` Chris Wilson
2019-10-28  8:24   ` Takashi Iwai [this message]
2019-10-28 11:09     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Alsa-Devel Archive on

Archives are clonable:
	git clone --mirror alsa-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 alsa-devel alsa-devel/ \
	public-inbox-index alsa-devel

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone