From: Takashi Iwai <tiwai@suse.de>
To: Pawel Harlozinski <pawel.harlozinski@linux.intel.com>
Cc: cezary.rojewski@intel.com, patch@alsa-project.org,
alsa-devel@alsa-project.org,
pierre-louis.bossart@linux.intel.com, lgirdwood@gmail.com,
broonie@kernel.org
Subject: Re: [alsa-devel] [RFC PATCH 1/3] ALSA:hda: Simplify and clear calculating SDxFMT
Date: Thu, 05 Sep 2019 07:47:24 +0200 [thread overview]
Message-ID: <s5hblvzguqb.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190905053302.9262-1-pawel.harlozinski@linux.intel.com>
On Thu, 05 Sep 2019 07:32:59 +0200,
Pawel Harlozinski wrote:
>
> Set SDxFMT based only on given format, due to maxbps not always being set.
> Split cases for formats 20,24,32 bits.
> For format SNDRV_PCM_FORMAT_FLOAT_LE width is equal 32 so it will end up
> with same mask.
This function corresponds to snd_hdac_query_supported_pcm(), so this
patch breaks.
Basically the cases of 20 and 24 are superfluous and can be dropped.
It's there just to be sure.
Takashi
>
> Signed-off-by: Pawel Harlozinski <pawel.harlozinski@linux.intel.com>
> ---
> sound/hda/hdac_device.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/sound/hda/hdac_device.c b/sound/hda/hdac_device.c
> index b26cc93e7e10..add758e11b85 100644
> --- a/sound/hda/hdac_device.c
> +++ b/sound/hda/hdac_device.c
> @@ -759,14 +759,13 @@ unsigned int snd_hdac_calc_stream_format(unsigned int rate,
> val |= AC_FMT_BITS_16;
> break;
> case 20:
> + val |= AC_FMT_BITS_20;
> + break;
> case 24:
> + val |= AC_FMT_BITS_24;
> + break;
> case 32:
> - if (maxbps >= 32 || format == SNDRV_PCM_FORMAT_FLOAT_LE)
> - val |= AC_FMT_BITS_32;
> - else if (maxbps >= 24)
> - val |= AC_FMT_BITS_24;
> - else
> - val |= AC_FMT_BITS_20;
> + val |= AC_FMT_BITS_32;
> break;
> default:
> return 0;
> --
> 2.17.1
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-09-05 5:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 5:32 [alsa-devel] [RFC PATCH 1/3] ALSA:hda: Simplify and clear calculating SDxFMT Pawel Harlozinski
2019-09-05 5:33 ` [alsa-devel] [RFC PATCH 2/3] ALSA:core: Add rate 24kHz Pawel Harlozinski
2019-09-05 5:48 ` Takashi Iwai
2019-09-05 13:11 ` Pierre-Louis Bossart
2019-09-05 13:16 ` Takashi Iwai
2019-09-05 14:00 ` Pierre-Louis Bossart
2019-09-05 14:09 ` Takashi Iwai
2019-09-05 5:33 ` [alsa-devel] [RFC PATCH 3/3] ALSA:hda: Add rates 24kHz, 64kHz Pawel Harlozinski
2019-09-05 5:33 ` Pawel Harlozinski
2019-09-05 5:47 ` Takashi Iwai [this message]
2019-09-06 13:41 ` [alsa-devel] [RFC PATCH 1/3] ALSA:hda: Simplify and clear calculating SDxFMT Harlozinski, Pawel
2019-09-06 14:16 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hblvzguqb.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=lgirdwood@gmail.com \
--cc=patch@alsa-project.org \
--cc=pawel.harlozinski@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).