From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEE12C433E0 for ; Wed, 24 Feb 2021 07:58:32 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A95864ECF for ; Wed, 24 Feb 2021 07:58:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A95864ECF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E9595950; Wed, 24 Feb 2021 08:57:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E9595950 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1614153509; bh=kIkouKXsZgjxF/o65a/G1l/mV8WJrbjozZYFEJDL69A=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nJmeQtLeNWVizFhFUeDLBTsKp/i3MZMTG+X53mZkMeVaDCwFQdFm0LNS/SctkhXEj bx6CepyNYiVX0FGjMtYEKqq44pF9IzsAWv1hMMmJUIiRdGQJQQ5tZoHb9hq191tatr B09M0ts5Wgs3DKJLGPxozxoo/BZdp0vHmtsZ5ohI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6A450F80161; Wed, 24 Feb 2021 08:57:38 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BFFA0F8016C; Wed, 24 Feb 2021 08:57:36 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 415A5F80129 for ; Wed, 24 Feb 2021 08:57:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 415A5F80129 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 267D1AD2B; Wed, 24 Feb 2021 07:57:29 +0000 (UTC) Date: Wed, 24 Feb 2021 08:57:28 +0100 Message-ID: From: Takashi Iwai To: George Harker Subject: Re: [PATCH] sound/usb generate midi streaming substream names from jack names In-Reply-To: <20210221094333.30499-1-george@george-graphics.co.uk> References: <20210221094148.30447-1-george@george-graphics.co.uk> <20210221094333.30499-1-george@george-graphics.co.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Clemens Ladisch , Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, 21 Feb 2021 10:43:32 +0100, George Harker wrote: > > A number of devices have named substreams which are hard to remember / > decypher from MIDI n names. Eg. Korg puts a pass through on > one substream and iConnectivity devices name the connections. > > This makes it easier to connect to the correct device. Devices which > handle naming through quirks are unaffected by this change. > > Addresses TODO comment in sound/usb/midi.c > > Signed-off-by: George Harker The code changes look almost OK, but could you try the following? - Split the patch: one for rewriting with the structs in linux/usb/midi.h, another for adding the MIDI device name support - Try to avoid magic numbers: a few places should be replaced with sizeof() or ARRAY_SIZE(). thanks, Takashi