From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80EECC83007 for ; Wed, 29 Apr 2020 07:28:59 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 108532076B for ; Wed, 29 Apr 2020 07:28:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="KnDiipUZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 108532076B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 713A81679; Wed, 29 Apr 2020 09:28:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 713A81679 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1588145337; bh=ogwmjKYJvW8yi7PJGlhbzKAqGMvu1BYhWpLT4vD2700=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=KnDiipUZ1C3a79UhCKEPKwlICkk3pktXA+S1bhFl/iGsdWJrOByOOhGfj4MYtKz5c MFDiqFq2PTbcOe7I+hcBkboQ/6mu52cV5tVVUTc43BHJJEWTXTleJQmcrqlRD1LXe5 b0JCwmrD9XzVeewGeHs4MGRtXsdWn4+WCXYD4cJ4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5295DF80217; Wed, 29 Apr 2020 09:28:02 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3E7CDF8022B; Wed, 29 Apr 2020 09:27:59 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 868F1F800D2 for ; Wed, 29 Apr 2020 09:27:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 868F1F800D2 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 5A782ABCC; Wed, 29 Apr 2020 07:27:53 +0000 (UTC) Date: Wed, 29 Apr 2020 09:27:53 +0200 Message-ID: From: Takashi Iwai To: Wu Bo Subject: Re: [PATCH] sound:hdmi:fix without unlocked before return In-Reply-To: <1587907042-694161-1-git-send-email-wubo40@huawei.com> References: <1587907042-694161-1-git-send-email-wubo40@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: pierre-louis.bossart@linux.intel.com, nmahale@nvidia.com, kai.vehmanen@linux.intel.com, aplattner@nvidia.com, linux-kernel@vger.kernel.org, tiwai@suse.com, linfeilong@huawei.com, libin.yang@linux.intel.com, alsa-devel@alsa-project.org, liuzhiqiang26@huawei.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, 26 Apr 2020 15:17:22 +0200, Wu Bo wrote: > > Fix the following coccicheck warning: > sound/pci/hda/patch_hdmi.c:1852:2-8: preceding lock on line 1846 > > After add sanity check to pass klockwork check, > The spdif_mutex should be unlock before return true > in check_non_pcm_per_cvt(). > > Signed-off-by: Wu Bo Applied now with the correction of subject and Fixes tag as well as Cc-to-stable tag. thanks, Takashi