From: Takashi Iwai <tiwai@suse.de>
To: erwin <nebelbank@posteo.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH - alsa-utils 1/1] aplay: Fix wav file not being split on 32 bit platforms
Date: Tue, 13 Mar 2018 19:54:45 +0100 [thread overview]
Message-ID: <s5hefknlsay.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180313185124.5352-1-nebelbank@posteo.de>
On Tue, 13 Mar 2018 19:51:24 +0100,
erwin wrote:
>
> On my 32 bit armhf board arecord exits because of write() returning EFBIG
> when the output file size reaches 2147483647 bytes.
>
> To fix this, include generated header file before system header files
> so that _FILE_OFFSET_BITS=64 is used properly, as required in documentation
> "man feature_test_macros".
>
> Signed-off-by: erwin <nebelbank@posteo.de>
Thanks, the change looks good. But sign-off is usually with a real
name, otherwise it doesn't make sense from the legal POV (that's the
reason of sign-off, after all).
If you really don't want to expose the name, I can drop it, of
course. We don't mandate the sign-off in the user-space repos unlike
Linux kernel tree, so far.
Takashi
next prev parent reply other threads:[~2018-03-13 18:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 18:51 [PATCH - alsa-utils 1/1] aplay: Fix wav file not being split on 32 bit platforms erwin
2018-03-13 18:54 ` Takashi Iwai [this message]
2018-03-13 19:27 ` erwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hefknlsay.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=nebelbank@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).