From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH - alsa-utils 1/1] aplay: Fix wav file not being split on 32 bit platforms Date: Tue, 13 Mar 2018 19:54:45 +0100 Message-ID: References: <20180313185124.5352-1-nebelbank@posteo.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id C8C80266E77 for ; Tue, 13 Mar 2018 19:54:45 +0100 (CET) In-Reply-To: <20180313185124.5352-1-nebelbank@posteo.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: erwin Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Tue, 13 Mar 2018 19:51:24 +0100, erwin wrote: > > On my 32 bit armhf board arecord exits because of write() returning EFBIG > when the output file size reaches 2147483647 bytes. > > To fix this, include generated header file before system header files > so that _FILE_OFFSET_BITS=64 is used properly, as required in documentation > "man feature_test_macros". > > Signed-off-by: erwin Thanks, the change looks good. But sign-off is usually with a real name, otherwise it doesn't make sense from the legal POV (that's the reason of sign-off, after all). If you really don't want to expose the name, I can drop it, of course. We don't mandate the sign-off in the user-space repos unlike Linux kernel tree, so far. Takashi