alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Olivia Mackintosh <livvy@base.nu>
Cc: alsa-devel@alsa-project.org, Fabian Lesniak <fabian@lesniak-it.de>
Subject: Re: [PATCH v2 0/2] Add DJM-750 and simplify
Date: Thu, 04 Feb 2021 08:03:53 +0100	[thread overview]
Message-ID: <s5hft2c8gbq.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210204034432.15504-1-livvy@base.nu>

On Thu, 04 Feb 2021 04:44:30 +0100,
Olivia Mackintosh wrote:
> 
> This is a re-roll of my last patch with the addition of some
> improvements. Hopefully it reduces the noise a little and simplifies the
> adding of new devices. One thing I haven't done here is replace the
> arrays of values for each channel with a named definition. In order to
> do this, the actual wValue would need to include the channel mask.
> 
> Olivia Mackintosh (2):
>   ALSA: usb-audio: Add DJM750 to Pioneer mixer quirk
>   ALSA: usb-audio: Simplify DJM mixer quirks

checkpatch.pl complains a few things in both patches.  While many of
warnings can be ignored, some errors (e.g. the brace should be put in
the next line for the function definition) need to be addressed.

Could you fix and resubmit?


thanks,

Takashi

  reply	other threads:[~2021-02-04  7:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28 16:03 [PATCH] ALSA: usb-audio: Add DJM750 to Pioneer mixer quirk Olivia Mackintosh
2021-01-29 14:09 ` Fabian Lesniak
2021-01-29 15:13   ` Takashi Iwai
2021-01-29 15:21   ` Olivia Mackintosh
2021-02-01 15:34   ` František Kučera
2021-02-01 21:37     ` Fabian Lesniak
2021-02-02  1:08       ` Olivia Mackintosh
2021-02-04  3:44 ` [PATCH v2 0/2] Add DJM-750 and simplify Olivia Mackintosh
2021-02-04  7:03   ` Takashi Iwai [this message]
2021-02-04 19:39     ` [PATCH v3 0/1] " Olivia Mackintosh
2021-02-04 19:39       ` [PATCH v3 1/1] ALSA: usb-audio: Add DJM750 to Pioneer mixer quirk Olivia Mackintosh
2021-02-04 21:33         ` Takashi Iwai
2021-02-05 18:42           ` [PATCH v4 0/1] Add DJM-750 and simplify Olivia Mackintosh
2021-02-05 18:42             ` [PATCH v4 1/1] ALSA: usb-audio: Add DJM750 to Pioneer mixer quirk Olivia Mackintosh
2021-02-05 22:18               ` Takashi Iwai
2021-02-04  3:44 ` [PATCH v2 1/2] " Olivia Mackintosh
2021-02-04  3:44 ` [PATCH v2 2/2] ALSA: usb-audio: Simplify DJM mixer quirks Olivia Mackintosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hft2c8gbq.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=fabian@lesniak-it.de \
    --cc=livvy@base.nu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).