From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06F66C433DB for ; Tue, 26 Jan 2021 06:35:34 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12D8C22B51 for ; Tue, 26 Jan 2021 06:35:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12D8C22B51 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 75B3D17CA; Tue, 26 Jan 2021 07:34:41 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 75B3D17CA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1611642931; bh=SHlFLc1XY3K0MVMeYVNlIUWqdSGDFwpWzz4jwRSvdgM=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=PQNnMifphaUIeBtUX7aR8M2AfyS2GaNoiS1VZ5UIGjn5bTuHENuZdE64qXRR8Wa53 V61fKBKhTyJRAqcz+9nEI7a5odUuvfWXHH/E133K46cePVSdGvwBTVmuFaLg65m0Bi 8YlDBQy9IisJGW2BSRicZlWeVGDH20yiYTAXCEQI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0E509F804B1; Tue, 26 Jan 2021 07:34:19 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 269F9F804B4; Tue, 26 Jan 2021 07:34:17 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 03886F80217 for ; Tue, 26 Jan 2021 07:34:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 03886F80217 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A24B8AEAC; Tue, 26 Jan 2021 06:34:10 +0000 (UTC) Date: Tue, 26 Jan 2021 07:34:10 +0100 Message-ID: From: Takashi Iwai To: Dmitry Osipenko Subject: Re: [PATCH v3 3/6] ALSA: hda/tegra: Remove unnecessary null-check from hda_tegra_runtime_resume() In-Reply-To: <20210120003154.26749-4-digetx@gmail.com> References: <20210120003154.26749-1-digetx@gmail.com> <20210120003154.26749-4-digetx@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Nicolas Chauvet , linux-kernel@vger.kernel.org, Sameer Pujar , Takashi Iwai , Jonathan Hunter , Thierry Reding , Matt Merhar , Peter Geis , linux-tegra@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 20 Jan 2021 01:31:51 +0100, Dmitry Osipenko wrote: > > The "chip" can't be NULL in hda_tegra_runtime_resume() because code would > crash otherwise. Let's remove the unnecessary check in order to clean up > code a tad. > > Tested-by: Peter Geis # Ouya T30 audio works > Tested-by: Matt Merhar # Ouya T30 boot-tested > Suggested-by: Thierry Reding > Signed-off-by: Dmitry Osipenko Applied, thanks. Takashi