From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8E1CC433E2 for ; Fri, 11 Sep 2020 16:25:01 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00A6B22204 for ; Fri, 11 Sep 2020 16:24:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Gx9xXP3/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00A6B22204 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3318B1661; Fri, 11 Sep 2020 18:24:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3318B1661 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599841498; bh=OVTQErer3otg5QWGPJBV2e7W7ibTudBgb0rHScrpE44=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Gx9xXP3/cXL4fYCvfDgcL7jpg311VkHRlIQuEMYDwX/xkRI3GyfrMDGKDXBB7n5al enoJ5r16RSAB2u+X1I567MPRBdkUhKWV+LxJoHL45U/Jsh264FqlCabOWpWuRRTv9z dpc3/qe84ajgqrgVZ6S4OBo6fdnWXO6s4YaKE1T0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AC04EF8021C; Fri, 11 Sep 2020 18:24:07 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8BE53F80227; Fri, 11 Sep 2020 18:24:05 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 09CB0F80115 for ; Fri, 11 Sep 2020 18:23:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 09CB0F80115 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DA327B153; Fri, 11 Sep 2020 16:24:09 +0000 (UTC) Date: Fri, 11 Sep 2020 18:23:54 +0200 Message-ID: From: Takashi Iwai To: Takashi Sakamoto Subject: Re: [PATCH v2] ALSA: firewire: Replace tasklet with work In-Reply-To: <20200910114359.GA16550@workstation> References: <20200909163659.21708-1-tiwai@suse.de> <20200910114359.GA16550@workstation> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 10 Sep 2020 13:43:59 +0200, Takashi Sakamoto wrote: > > Hi, > > On Wed, Sep 09, 2020 at 06:36:59PM +0200, Takashi Iwai wrote: > > The tasklet is an old API that should be deprecated, usually can be > > converted to another decent API. In FireWire driver, a tasklet is > > still used for offloading the AMDTP PCM stream handling. It can be > > achieved gracefully with a work queued, too. > > > > This patch replaces the tasklet usage in firewire-lib driver with a > > simple work. The conversion is fairly straightforward but for the > > in_interrupt() checks that are replaced with the check using the > > current_work(). > > > > Note that in_interrupt() in amdtp_packet tracepoint is still kept as > > is. This is the place that is probed by both softirq of 1394 OHCI and > > a user task of a PCM application, and the work handling is already > > filtered in amdtp_domain_stream_pcm_pointer(). > > > > Signed-off-by: Takashi Iwai > > --- > > v1->v2: Drop in_interrupt() conversion in tracepoint > > > > sound/firewire/amdtp-stream.c | 25 +++++++++++++------------ > > sound/firewire/amdtp-stream.h | 2 +- > > 2 files changed, 14 insertions(+), 13 deletions(-) > > The v2 patch looks good to me. > > Tested-by: Takashi Sakamoto > Acked-by: Takashi Sakamoto > > Thanks for your work! Thanks for a quick review. Now I applied it. Takashi