From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45958C47256 for ; Sun, 3 May 2020 07:27:05 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A07C42075B for ; Sun, 3 May 2020 07:27:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="QUtWgCFZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A07C42075B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DC24816AB; Sun, 3 May 2020 09:26:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DC24816AB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1588490822; bh=sp6OH6sC+d6QlX1FCFNGovdQ6BtE0VKyu9J4r2ApVRM=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=QUtWgCFZCGcQhskreTzGf7yXh66EMHXEnAYa5vbIP06xoRCpcSSO5ZvaQUDpJeyhK Mz9jhlDNXKJgTBo4KwnGKLzuc7bMNTIhiWdPtsseR/1eHyNBMTm5mKeEhCLtmllj/8 SCr7KfuluLHBfyXagJZMo/rB9TeLqHSzhwGFoz94= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6EC09F8015B; Sun, 3 May 2020 09:26:12 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6E6B9F8015F; Sun, 3 May 2020 09:25:58 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 98265F800DA for ; Sun, 3 May 2020 09:25:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 98265F800DA X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 3123CAE37; Sun, 3 May 2020 07:25:52 +0000 (UTC) Date: Sun, 03 May 2020 09:25:50 +0200 Message-ID: From: Takashi Iwai To: Takashi Sakamoto Subject: Re: [PATCH] ALSA: firewire-lib: fix 'function sizeof not defined' error of tracepoints format In-Reply-To: <20200503045718.86337-1-o-takashi@sakamocchi.jp> References: <20200503045718.86337-1-o-takashi@sakamocchi.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, clemens@ladisch.de, stable@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, 03 May 2020 06:57:18 +0200, Takashi Sakamoto wrote: > > The snd-firewire-lib.ko has 'amdtp-packet' event of tracepoints. Current > printk format for the event includes 'sizeof(u8)' macro expected to be > extended in compilation time. However, this is not done. As a result, > perf tools cannot parse the event for printing: > > $ mount -l -t debugfs > debugfs on /sys/kernel/debug type debugfs (rw,nosuid,nodev,noexec,relatime) > $ cat /sys/kernel/debug/tracing/events/snd_firewire_lib/amdtp_packet/format > ... > print fmt: "%02u %04u %04x %04x %02d %03u %02u %03u %02u %01u %02u %s", > REC->second, REC->cycle, REC->src, REC->dest, REC->channel, > REC->payload_quadlets, REC->data_blocks, REC->data_block_counter, > REC->packet_index, REC->irq, REC->index, > __print_array(__get_dynamic_array(cip_header), > __get_dynamic_array_len(cip_header), > sizeof(u8)) > > $ sudo perf record -e snd_firewire_lib:amdtp_packet > [snd_firewire_lib:amdtp_packet] function sizeof not defined > Error: expected type 5 but read 0 > > This commit fixes it by obsoleting the macro with actual size. > > Cc: > Fixes: bde2bbdb307a: ("ALSA: firewire-lib: use dynamic array for CIP header of tracing events") > Signed-off-by: Takashi Sakamoto Applied now with a correction of Fixes tag (removal of the superfluous colon after commit id). thanks, Takashi