From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16C33C49ED7 for ; Fri, 20 Sep 2019 07:45:20 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B24E207FC for ; Fri, 20 Sep 2019 07:45:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Wx/All7N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B24E207FC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CC774166A; Fri, 20 Sep 2019 09:44:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CC774166A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1568965517; bh=tGm1tBsA+65ov1IVFukRxY4oLx2zj42NpH+3iNIZ2Kc=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Wx/All7N5V9ZfqXFQ+aU63tFjBzI89jCAR7gE5iY56UnKhHFPdIjG9kSAV6TmiieV oS/5PlC+52T/43S+i6XJ8QWpXf2pL9ic4U6lAGo18VGEpyr6OI5DZXzbZuO8eQws1l 8a+dbdb/yO9r7wqAQJ+dri6fi4QCkISQk1+CjQhk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3AF0AF804FF; Fri, 20 Sep 2019 09:44:27 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 60C09F80506; Fri, 20 Sep 2019 09:44:25 +0200 (CEST) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3C282F800C7 for ; Fri, 20 Sep 2019 09:44:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3C282F800C7 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id AFEC7B676; Fri, 20 Sep 2019 07:44:21 +0000 (UTC) Date: Fri, 20 Sep 2019 09:44:19 +0200 Message-ID: From: Takashi Iwai To: Tanu Kaskinen In-Reply-To: <7c81ae80233efb25b25f2d1f941e9c11acb3967b.camel@iki.fi> References: <20190904164706.gwjbcywbj7emnwvr@localhost> <20190910173345.63bv2xa4vlkxicxj@localhost> <365e4bcc033c151076140471225db51c80808b7f.camel@iki.fi> <20190919211244.buu3d6ey4k2dxyul@localhost> <7c81ae80233efb25b25f2d1f941e9c11acb3967b.camel@iki.fi> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org, frederik@ofb.net Subject: Re: [alsa-devel] parameter for pulse device? X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 20 Sep 2019 09:35:59 +0200, Tanu Kaskinen wrote: > > On Thu, 2019-09-19 at 14:12 -0700, frederik@ofb.net wrote: > > Thank you for the tips. > > > > I don't know if my input is still needed, but I figured out from > > looking at some of the syntax you linked to that I can put this in > > ~/.asoundrc and it does the job (this is what I had had in mind when > > I asked about "magic with macros", it is somewhat advanced for me): > > > > pcm.!pulse { > > @args [ DEV ] > > @args.DEV { > > type string > > default "default" > > } > > type pulse; > > device $DEV > > } > > > > Now I can set up a filter like this: > > > > ecasound -i alsa,pulse:mic -o alsa,pulse:monitor > > > > Is something like this going into the alsa-plugins repo? > > I'm sure something like this will be accepted if you submit a patch. I > got the impression that Takashi isn't willing to write the patch > himself, and nor am I, so you're in the best position to make this > happen. I have a test patch but had no chance to test the stuff at all currently as I am (and will be for the next few weeks) traveling. > Note that > > default "default" > > doesn't do the intended thing with the current pcm_pulse.c code. With > the current code the plugin will request PulseAudio to use a device > named "default", which most likely won't exist and playback or > recording will fail. The plugin code needs to pass NULL as the device > name to pa_stream_connect_playback() and pa_stream_connect_record() > when it detects that the default device is requested, so you'll need to > modify pcm_pulse.c in order to make this work. Instead of "default" as > the special string in the configuration, I suggested using "". Below is the totally untested patch (even not build-tested!) If anyone interested, feel free to cook it. thanks, Takashi --- diff --git a/pulse/50-pulseaudio.conf b/pulse/50-pulseaudio.conf index 62da207af9ca..916258d942af 100644 --- a/pulse/50-pulseaudio.conf +++ b/pulse/50-pulseaudio.conf @@ -1,7 +1,13 @@ # Add a specific named PulseAudio pcm and ctl (typically useful for testing) pcm.pulse { + @args [ DEVICE ] + @args.DEVICE { + type string + default "" + } type pulse + device $DEVICE hint { show { @func refer diff --git a/pulse/ctl_pulse.c b/pulse/ctl_pulse.c index fbb6eae2ec76..9b820fd04b15 100644 --- a/pulse/ctl_pulse.c +++ b/pulse/ctl_pulse.c @@ -664,6 +664,8 @@ SND_CTL_PLUGIN_DEFINE_FUNC(pulse) if (snd_config_get_string(n, &server) < 0) { SNDERR("Invalid type for %s", id); return -EINVAL; + } else if (!*server) { + server = NULL; } continue; } @@ -671,6 +673,8 @@ SND_CTL_PLUGIN_DEFINE_FUNC(pulse) if (snd_config_get_string(n, &device) < 0) { SNDERR("Invalid type for %s", id); return -EINVAL; + } else if (!*device) { + device = NULL; } continue; } @@ -678,6 +682,8 @@ SND_CTL_PLUGIN_DEFINE_FUNC(pulse) if (snd_config_get_string(n, &source) < 0) { SNDERR("Invalid type for %s", id); return -EINVAL; + } else if (!*source) { + source = NULL; } continue; } @@ -685,6 +691,8 @@ SND_CTL_PLUGIN_DEFINE_FUNC(pulse) if (snd_config_get_string(n, &sink) < 0) { SNDERR("Invalid type for %s", id); return -EINVAL; + } else if (!*sink) { + sink = NULL; } continue; } diff --git a/pulse/pcm_pulse.c b/pulse/pcm_pulse.c index 283174357e8b..869c9b674c6b 100644 --- a/pulse/pcm_pulse.c +++ b/pulse/pcm_pulse.c @@ -1069,6 +1069,8 @@ SND_PCM_PLUGIN_DEFINE_FUNC(pulse) if (snd_config_get_string(n, &server) < 0) { SNDERR("Invalid type for %s", id); return -EINVAL; + } else if (!*server) { + server = NULL; } continue; } @@ -1076,6 +1078,8 @@ SND_PCM_PLUGIN_DEFINE_FUNC(pulse) if (snd_config_get_string(n, &device) < 0) { SNDERR("Invalid type for %s", id); return -EINVAL; + } else if (!*device) { + device = NULL; } continue; } @@ -1091,6 +1095,8 @@ SND_PCM_PLUGIN_DEFINE_FUNC(pulse) if (snd_config_get_string(n, &fallback_name) < 0) { SNDERR("Invalid value for %s", id); return -EINVAL; + } else if (!*fallback_name) { + fallback_name = NULL; } continue; } _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel