Alsa-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de
Subject: Re: [PATCH 00/14] ALSA: firewire-motu: code refactoring to obsolete protocol structure
Date: Fri, 22 May 2020 16:53:50 +0200
Message-ID: <s5himgoxbpd.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200519111641.123211-1-o-takashi@sakamocchi.jp>

On Tue, 19 May 2020 13:16:27 +0200,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> ALSA firewire-motu driver becomes to support more models since its first
> commit 2017. As a result, the original structure for generation-dependent
> protocol is not suitable for differences between models in some cases.
> 
> This patchset is for refactoring the driver to obsolete the protocol
> structure. Some helper functions are added with condition statement for
> protocol version so that the function calls protocol-dependent function.
> Instead of the protocol structure, specification structure is used to
> represent model information and to choose model-dependent operation so
> that it's easy to handle model-dependent quirks.
> 
> Additionally, this patchset changes the way to calculate the number of
> chunks in data block. Current implementation calculates by the fixed
> number of analog input/output ports and flags in the specification
> structure. Although the flags can represent any physical input/output
> of the model, it's difficult to debug for supported model and to add
> support new models, especially for model-dependent quirks. This
> patchset adds each table for the fixed number of chunks of each model.
> The calculation is just done for differed part of chunks.
> 
> Takashi Sakamoto (14):
>   ALSA: firewire-motu: move spec data to v2 protocol file
>   ALSA: firewire-motu: move spec data to v3 protocol file
>   ALSA: firewire-motu: localize protocol data
>   ALSA: firewire-motu: add wrapper functions for protocol-dependent
>     operations
>   ALSA: firewire-motu: drop protocol structure
>   ALSA: firewire-motu: add model-specific table of chunk count
>   ALSA: firewire-motu: add alternative functions to detect packet format
>     for protocol v2
>   ALSA: firewire-motu: add alternative functions to detect packet format
>     for protocol v3
>   ALSA: firewire-motu: use table-based calculation of packet formats for
>     proc
>   ALSA: firewire-motu: use table-based calculation of packet formats for
>     stream management
>   ALSA: firewire-motu: remove obsoleted codes
>   ALSA: firewire-motu: refactoring protocol v2 for clock source getter
>   ALSA: firewire-motu: refactoring protocol v3 for clock source getter
>   ALSA: firewire-motu: refactoring protocol v2 for fetching mode switch

Applied all 14 patches now to for-next branch.


thanks,

Takashi

      parent reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 11:16 Takashi Sakamoto
2020-05-19 11:16 ` [PATCH 01/14] ALSA: firewire-motu: move spec data to v2 protocol file Takashi Sakamoto
2020-05-19 11:16 ` [PATCH 02/14] ALSA: firewire-motu: move spec data to v3 " Takashi Sakamoto
2020-05-19 11:16 ` [PATCH 03/14] ALSA: firewire-motu: localize protocol data Takashi Sakamoto
2020-05-19 11:16 ` [PATCH 04/14] ALSA: firewire-motu: add wrapper functions for protocol-dependent operations Takashi Sakamoto
2020-05-19 11:16 ` [PATCH 05/14] ALSA: firewire-motu: drop protocol structure Takashi Sakamoto
2020-05-19 11:16 ` [PATCH 06/14] ALSA: firewire-motu: add model-specific table of chunk count Takashi Sakamoto
2020-05-19 11:16 ` [PATCH 07/14] ALSA: firewire-motu: add alternative functions to detect packet format for protocol v2 Takashi Sakamoto
2020-05-19 11:16 ` [PATCH 08/14] ALSA: firewire-motu: add alternative functions to detect packet format for protocol v3 Takashi Sakamoto
2020-05-19 11:16 ` [PATCH 09/14] ALSA: firewire-motu: use table-based calculation of packet formats for proc Takashi Sakamoto
2020-05-19 11:16 ` [PATCH 10/14] ALSA: firewire-motu: use table-based calculation of packet formats for stream management Takashi Sakamoto
2020-05-19 11:16 ` [PATCH 11/14] ALSA: firewire-motu: remove obsoleted codes Takashi Sakamoto
2020-05-19 11:16 ` [PATCH 12/14] ALSA: firewire-motu: refactoring protocol v2 for clock source getter Takashi Sakamoto
2020-05-19 11:16 ` [PATCH 13/14] ALSA: firewire-motu: refactoring protocol v3 " Takashi Sakamoto
2020-05-19 11:16 ` [PATCH 14/14] ALSA: firewire-motu: refactoring protocol v2 for fetching mode switch Takashi Sakamoto
2020-05-22 14:53 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5himgoxbpd.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=o-takashi@sakamocchi.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Alsa-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/alsa-devel/0 alsa-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 alsa-devel alsa-devel/ https://lore.kernel.org/alsa-devel \
		alsa-devel@alsa-project.org
	public-inbox-index alsa-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.alsa-project.alsa-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git