From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63CD9C433DF for ; Fri, 22 May 2020 14:54:50 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E84322224A for ; Fri, 22 May 2020 14:54:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="QBM5BKUN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E84322224A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 341EB16FB; Fri, 22 May 2020 16:53:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 341EB16FB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1590159288; bh=aaj7PUw/6q00RZhLnx1KwXmVs9U0mA8TmlkJGA76iwc=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=QBM5BKUNbNXvOsdXZxYssXP31rvxdwDRGz4LaOF0RPETXuZHGmzUg/A1Qqq0a/vCG 6puHT++4pxUfQ0FCVPzoRD8j2Cac05vbTmn7TQtRoCU29chFtvhZDzYnXZqfmVPiNT zK2wrjy0LbL+J34SRe+zdI0VmlVtzbDUrwut0NCQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C65A8F801DA; Fri, 22 May 2020 16:53:57 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A0382F801F9; Fri, 22 May 2020 16:53:56 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E4836F80111 for ; Fri, 22 May 2020 16:53:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E4836F80111 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 179C3AB89; Fri, 22 May 2020 14:53:54 +0000 (UTC) Date: Fri, 22 May 2020 16:53:50 +0200 Message-ID: From: Takashi Iwai To: Takashi Sakamoto Subject: Re: [PATCH 00/14] ALSA: firewire-motu: code refactoring to obsolete protocol structure In-Reply-To: <20200519111641.123211-1-o-takashi@sakamocchi.jp> References: <20200519111641.123211-1-o-takashi@sakamocchi.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, clemens@ladisch.de X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 19 May 2020 13:16:27 +0200, Takashi Sakamoto wrote: > > Hi, > > ALSA firewire-motu driver becomes to support more models since its first > commit 2017. As a result, the original structure for generation-dependent > protocol is not suitable for differences between models in some cases. > > This patchset is for refactoring the driver to obsolete the protocol > structure. Some helper functions are added with condition statement for > protocol version so that the function calls protocol-dependent function. > Instead of the protocol structure, specification structure is used to > represent model information and to choose model-dependent operation so > that it's easy to handle model-dependent quirks. > > Additionally, this patchset changes the way to calculate the number of > chunks in data block. Current implementation calculates by the fixed > number of analog input/output ports and flags in the specification > structure. Although the flags can represent any physical input/output > of the model, it's difficult to debug for supported model and to add > support new models, especially for model-dependent quirks. This > patchset adds each table for the fixed number of chunks of each model. > The calculation is just done for differed part of chunks. > > Takashi Sakamoto (14): > ALSA: firewire-motu: move spec data to v2 protocol file > ALSA: firewire-motu: move spec data to v3 protocol file > ALSA: firewire-motu: localize protocol data > ALSA: firewire-motu: add wrapper functions for protocol-dependent > operations > ALSA: firewire-motu: drop protocol structure > ALSA: firewire-motu: add model-specific table of chunk count > ALSA: firewire-motu: add alternative functions to detect packet format > for protocol v2 > ALSA: firewire-motu: add alternative functions to detect packet format > for protocol v3 > ALSA: firewire-motu: use table-based calculation of packet formats for > proc > ALSA: firewire-motu: use table-based calculation of packet formats for > stream management > ALSA: firewire-motu: remove obsoleted codes > ALSA: firewire-motu: refactoring protocol v2 for clock source getter > ALSA: firewire-motu: refactoring protocol v3 for clock source getter > ALSA: firewire-motu: refactoring protocol v2 for fetching mode switch Applied all 14 patches now to for-next branch. thanks, Takashi