From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EFD0C432C0 for ; Fri, 22 Nov 2019 18:15:50 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BA082067D for ; Fri, 22 Nov 2019 18:15:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="W9TfRYuc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BA082067D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E9782183E; Fri, 22 Nov 2019 19:14:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E9782183E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1574446547; bh=7jttTG8HwJrOtDnNnT1uKH2dQfdE25UxGmptOe56p1I=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=W9TfRYucXUYUGoXpFNT1TGcYaQc605tNkbwgqv5156vSi+dhBIisPTkxjNLHROKrQ kskMiZdqBCivWK1KrRAQPs4pFcq3ssAWLqCo4KYcEBcS7jmBJXqJZLHeohfczkO+5B inV9SmvHa1tTi+aq94TFQWitj6o5bD18sFuNJ0ko= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 471D6F8014A; Fri, 22 Nov 2019 19:14:11 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id EAF02F80159; Fri, 22 Nov 2019 19:14:09 +0100 (CET) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6BD77F8014A for ; Fri, 22 Nov 2019 19:14:06 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6BD77F8014A X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 154AAAFA1; Fri, 22 Nov 2019 18:14:06 +0000 (UTC) Date: Fri, 22 Nov 2019 19:14:06 +0100 Message-ID: From: Takashi Iwai To: Andrew Gabbasov In-Reply-To: <20191122175218.17187-2-andrew_gabbasov@mentor.com> References: <20191122175218.17187-1-andrew_gabbasov@mentor.com> <20191122175218.17187-2-andrew_gabbasov@mentor.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: Timo Wischer , alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH 2/2] ALSA: aloop: Avoid unexpected timer event callback tasklets X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 22 Nov 2019 18:52:18 +0100, Andrew Gabbasov wrote: > > loopback_snd_timer_close_cable() function waits until all > scheduled tasklets are completed, but the timer is closed after that > and can generate more event callbacks, scheduling new tasklets, > that will not be synchronized with cable closing. > Move tasklet_kill() call to be executed after snd_timer_close() > call to avoid such case. > > Fixes: 26c53379f98d ("ALSA: aloop: Support selection of snd_timer instead of jiffies") > Signed-off-by: Andrew Gabbasov Applied, thanks. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel