From: Takashi Iwai <tiwai@suse.de>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: "moderated list:SOUND" <alsa-devel@alsa-project.org>,
Randy Dunlap <rdunlap@infradead.org>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Harsha Priya <harshapriya.n@intel.com>,
open list <linux-kernel@vger.kernel.org>,
tiwai@suse.com,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 1/4] ALSA: hda: Refactor codec PM to use direct-complete optimization
Date: Fri, 23 Oct 2020 13:32:04 +0200 [thread overview]
Message-ID: <s5hk0vh89fv.wl-tiwai@suse.de> (raw)
In-Reply-To: <20201023102340.25494-1-kai.heng.feng@canonical.com>
On Fri, 23 Oct 2020 12:23:35 +0200,
Kai-Heng Feng wrote:
>
> +static void hda_codec_pm_complete(struct device *dev)
> {
> struct hda_codec *codec = dev_to_hda_codec(dev);
> - int ret;
>
> - ret = pm_runtime_force_resume(dev);
> - /* schedule jackpoll work for jack detection update */
> - if (codec->jackpoll_interval ||
> - (pm_runtime_suspended(dev) && hda_codec_need_resume(codec)))
> - schedule_delayed_work(&codec->jackpoll_work,
> - codec->jackpoll_interval);
> - return ret;
> + if (pm_runtime_suspended(dev) &&
> + (hda_codec_need_resume(codec) || codec->forced_resume))
> + pm_request_resume(dev);
You shouldn't drop the check of codec->jackpoll_interval. If this
field is set, the codec driver has to resume no matter what it was, so
that the polling can start up again.
thanks,
Takashi
next prev parent reply other threads:[~2020-10-23 11:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 10:23 [PATCH 1/4] ALSA: hda: Refactor codec PM to use direct-complete optimization Kai-Heng Feng
2020-10-23 10:23 ` [PATCH 2/4] ALSA: hda: Stop mangling PCI MSI Kai-Heng Feng
2020-10-23 11:34 ` Takashi Iwai
2020-10-23 12:53 ` Kai-Heng Feng
2020-10-23 12:59 ` Takashi Iwai
2020-10-23 10:23 ` [PATCH 3/4] ALSA: hda: Refactor controller PM to use direct-complete optimization Kai-Heng Feng
2020-10-23 11:36 ` Takashi Iwai
2020-10-23 13:02 ` Kai-Heng Feng
2020-10-23 15:31 ` kernel test robot
2020-10-23 10:23 ` [PATCH 4/4] ALSA: hda: Reinstate runtime_allow() for all hda controllers Kai-Heng Feng
2020-10-23 11:32 ` Takashi Iwai [this message]
2020-10-23 12:44 ` [PATCH 1/4] ALSA: hda: Refactor codec PM to use direct-complete optimization Kai-Heng Feng
2020-10-23 13:04 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk0vh89fv.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gustavo@embeddedor.com \
--cc=harshapriya.n@intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=rdunlap@infradead.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).