alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Junar Wohn <doomsheart@gmail.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.com
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Notebook Pen S
Date: Wed, 08 Jul 2020 19:32:16 +0200	[thread overview]
Message-ID: <s5hk0zdap5r.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAHcbMh1MPsqkAYYHk9ycq7-Mivyog_BgRJFrVT+UDVohN0bg9A@mail.gmail.com>

On Wed, 08 Jul 2020 18:24:12 +0200,
Junar Wohn wrote:
> 
> Signed-off-by: Joonho Wohn <doomsheart@gmail.com>

Could you give a bit more description about your change above the
sign-off line?  Basically no description is a sign of a bad patch.

In the submission, you've put more texts in the subject line.
Just move some texts to the patch description area.


thanks,

Takashi

  reply	other threads:[~2020-07-08 17:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08 16:24 [PATCH] ALSA: hda/realtek: Add quirk for Samsung Notebook Pen S Junar Wohn
2020-07-08 17:32 ` Takashi Iwai [this message]
2020-07-08 17:43 Junar Wohn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hk0zdap5r.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=doomsheart@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).