From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1854C2BA16 for ; Tue, 7 Apr 2020 07:52:27 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EA952072A for ; Tue, 7 Apr 2020 07:52:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Fhh8FKfU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EA952072A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B492382A; Tue, 7 Apr 2020 09:51:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B492382A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1586245945; bh=ycOlBtAM5mST6xOSoTyCogrSZLIAz+unG6jBsaeOwwg=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Fhh8FKfUnfMhVcD5LoNbTDJsbNG/16qpHQwpVC+nNJPQlhncxAKvB+9PHGTj2z70k xYzLzpgx8bpmpycwaLtrSwxg2jRUP0Qhh0nuANCmyQ9wuli8+6UhJpGzcP0Og22E3C i+Mqfzrs1cn5xhBlDQHz9ktyJHHvg5816FESm47M= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4D79DF8011B; Tue, 7 Apr 2020 09:51:35 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9CD5FF801D8; Tue, 7 Apr 2020 09:51:31 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2F3D8F8011B for ; Tue, 7 Apr 2020 09:51:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2F3D8F8011B X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id B83F0AC84; Tue, 7 Apr 2020 07:51:26 +0000 (UTC) Date: Tue, 07 Apr 2020 09:51:27 +0200 Message-ID: From: Takashi Iwai To: Kailang Subject: Re: New HP mute led feature In-Reply-To: <6741211598ba499687362ff2aa30626b@realtek.com> References: <6741211598ba499687362ff2aa30626b@realtek.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: " \(alsa-devel@alsa-project.org\)" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 07 Apr 2020 09:05:49 +0200, Kailang wrote: > > Hi Takashi, > > I modified as attaches. Thanks. They had, however, a few typos that didn't compile, so I applied them with corrections. Please check the commits in sound git tree later. Takashi > > BR, > Kailang > > > -----Original Message----- > > From: Takashi Iwai > > Sent: Wednesday, April 1, 2020 2:18 PM > > To: Kailang > > Cc: (alsa-devel@alsa-project.org) > > Subject: Re: New HP mute led feature > > > > On Wed, 01 Apr 2020 07:37:50 +0200, > > Kailang wrote: > > > > > > Hi Takashi, > > > > > > HP had new mute led feature. > > > Attach two patches will enable it. > > > > They don't seem applied cleanly. > > Could you rebase to the latest git tree? > > > > Also, it might be worth unifying the handling. Both patches introduce very > > similar functions, and the values to mask and set can be referred, e.g. > > spec->coefbit_mask, etc. But such a cleanup can be done in a separate patch > > later, too. > > > > > > thanks, > > > > Takashi > > > > ------Please consider the environment before printing this e-mail. > [2 0001-hp-thinclient-0x877a-mute-led.patch ] > > [3 0002-hp-thinclient-0x877d-mute-led.patch ] >