From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D16D9C433E8 for ; Fri, 10 Jul 2020 14:01:06 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 610E12082E for ; Fri, 10 Jul 2020 14:01:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="N5/hzfK3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 610E12082E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B6DB686F; Fri, 10 Jul 2020 16:00:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B6DB686F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1594389664; bh=E1UMo79nazDXS2HoBWEk0jXKLl2XW5fGEJ50m0CWq/s=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=N5/hzfK30tdTAr4JA7MIAouGh0NVGRZwJ/jKnTq1EAzPP8mejW+HFNUHcHR/bazJv LB3YTRRJeK/SBBmwBZ05zQVjKzffa914aNnPUN4HzbWTi0NcM+9p9zfHRRzPJ1YRV6 5er7IIrcDFnAqf4oW6CG/GbiUGvaf8ZA5cS2jCQ4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3B605F80150; Fri, 10 Jul 2020 16:00:14 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A5AB0F8015A; Fri, 10 Jul 2020 16:00:11 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BD4C8F80117 for ; Fri, 10 Jul 2020 16:00:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BD4C8F80117 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 03D7DAC9F; Fri, 10 Jul 2020 14:00:00 +0000 (UTC) Date: Fri, 10 Jul 2020 15:59:59 +0200 Message-ID: From: Takashi Iwai To: Alan Stern Subject: Re: KASAN: use-after-free Read in line6_submit_audio_in_all_urbs In-Reply-To: <20200626182605.GA305214@rowland.harvard.edu> References: <000000000000d44c6d05a8ffe488@google.com> <20200626182605.GA305214@rowland.harvard.edu> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, syzbot , andreyknvl@google.com, linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org, tiwai@suse.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 26 Jun 2020 20:26:05 +0200, Alan Stern wrote: > > On Fri, Jun 26, 2020 at 10:18:12AM -0700, syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit: fb574682 usbip: tools: fix module name in man page > > git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing > > console output: https://syzkaller.appspot.com/x/log.txt?x=156560b1100000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=63b40b2ae167bad6 > > dashboard link: https://syzkaller.appspot.com/bug?extid=145012a46658ac00fc9e > > compiler: gcc (GCC) 10.1.0-syz 20200507 > > > > Unfortunately, I don't have any reproducer for this crash yet. > > > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > > Reported-by: syzbot+145012a46658ac00fc9e@syzkaller.appspotmail.com > > > > snd_usb_toneport 5-1:0.0: URB in #0 submission failed (-19) > > snd_usb_toneport 5-1:0.0: URB in #0 submission failed (-19) > > snd_usb_toneport 5-1:0.0: URB in #0 submission failed (-19) > > snd_usb_toneport 5-1:0.0: URB in #0 submission failed (-19) > > ================================================================== > > BUG: KASAN: use-after-free in line6_submit_audio_in_all_urbs+0x10b/0x120 sound/usb/line6/capture.c:72 > > Read of size 8 at addr ffff8881cffb1800 by task kworker/1:5/3257 > > > > CPU: 1 PID: 3257 Comm: kworker/1:5 Not tainted 5.8.0-rc1-syzkaller #0 > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > > Workqueue: events line6_startup_work > > Call Trace: > > __dump_stack lib/dump_stack.c:77 [inline] > > dump_stack+0xf6/0x16e lib/dump_stack.c:118 > > print_address_description.constprop.0+0x1a/0x210 mm/kasan/report.c:383 > > __kasan_report mm/kasan/report.c:513 [inline] > > kasan_report.cold+0x37/0x7c mm/kasan/report.c:530 > > line6_submit_audio_in_all_urbs+0x10b/0x120 sound/usb/line6/capture.c:72 > > line6_stream_start+0x207/0x230 sound/usb/line6/pcm.c:197 > > line6_pcm_acquire+0x161/0x210 sound/usb/line6/pcm.c:318 > > line6_startup_work+0x42/0x50 sound/usb/line6/driver.c:734 > > process_one_work+0x94c/0x15f0 kernel/workqueue.c:2269 > > worker_thread+0x64c/0x1120 kernel/workqueue.c:2415 > > kthread+0x392/0x470 kernel/kthread.c:291 > > ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:293 > > > > Allocated by task 76: > > save_stack+0x1b/0x40 mm/kasan/common.c:48 > > set_track mm/kasan/common.c:56 [inline] > > __kasan_kmalloc.constprop.0+0xc2/0xd0 mm/kasan/common.c:494 > > kmalloc include/linux/slab.h:555 [inline] > > kzalloc include/linux/slab.h:669 [inline] > > line6_init_pcm+0x2a7/0x9e0 sound/usb/line6/pcm.c:533 > > toneport_init+0xdd/0x6b0 sound/usb/line6/toneport.c:419 > > line6_probe+0xaa0/0x1330 sound/usb/line6/driver.c:809 > > It look like the cancel_delayed_work() in line6_disconnect() needs to be > cancel_delayed_work_sync(). Unfortunately we can't test this until syzbot > is able to reproduce the bug. Right, but fixing it now wouldn't be bad. The fix patch below. thanks, Takashi -- 8< -- From: Takashi Iwai Subject: [PATCH] ALSA: line6: Sync the pending work cancel at disconnection Recently syzkaller reported a UAF in LINE6 driver, and it's likely because we call cancel_delayed_work() at the disconnect callback instead of cancel_delayed_work_sync(). Let's use the correct one instead. Reported-by: syzbot+145012a46658ac00fc9e@syzkaller.appspotmail.com Suggested-by: Alan Stern Cc: Signed-off-by: Takashi Iwai --- sound/usb/line6/driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/usb/line6/driver.c b/sound/usb/line6/driver.c index 7629116f570e..2746d9698180 100644 --- a/sound/usb/line6/driver.c +++ b/sound/usb/line6/driver.c @@ -840,7 +840,7 @@ void line6_disconnect(struct usb_interface *interface) if (WARN_ON(usbdev != line6->usbdev)) return; - cancel_delayed_work(&line6->startup_work); + cancel_delayed_work_sync(&line6->startup_work); if (line6->urb_listen != NULL) line6_stop_listen(line6); -- 2.16.4