From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B931C43331 for ; Tue, 12 Nov 2019 20:29:07 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D769E21872 for ; Tue, 12 Nov 2019 20:29:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="oxUHaAM/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D769E21872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 133E0886; Tue, 12 Nov 2019 21:28:15 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 133E0886 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1573590545; bh=3DjelN9k1pTLJbZkdoN6k0nzzpxbQCyJwngpg8Ytchc=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oxUHaAM/fjetb43THDU1ybkIhP5+xkRSFM7jzs9UE+pIsU5E57Cg/1b0KJxhB3FU6 jBzg7lzPq4bIK6Pz438z0+QMPaWi1F26lXWrmbkGg6kRvnZfOO2pH3uBJ8nIgRzxZX 0utriw3cPPCpxh1Dkx19QMXAtk4Q4NIDN1THMWiU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id ABB52F8049C; Tue, 12 Nov 2019 21:28:14 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F142FF804CF; Tue, 12 Nov 2019 21:28:11 +0100 (CET) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7F535F802E0 for ; Tue, 12 Nov 2019 21:28:07 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7F535F802E0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4CDE7ACEC; Tue, 12 Nov 2019 20:28:06 +0000 (UTC) Date: Tue, 12 Nov 2019 21:28:06 +0100 Message-ID: From: Takashi Iwai To: Arnd Bergmann In-Reply-To: References: <20191112151642.680072-1-arnd@arndb.de> <20191112151642.680072-3-arnd@arndb.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: ALSA Development Mailing List , Baolin Wang , y2038 Mailman List , "linux-kernel@vger.kernel.org" , Takashi Iwai , Mark Brown , Baolin Wang Subject: Re: [alsa-devel] [PATCH v6 2/8] ALSA: Avoid using timespec for struct snd_timer_status X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 12 Nov 2019 21:08:17 +0100, Arnd Bergmann wrote: > > On Tue, Nov 12, 2019 at 4:42 PM Takashi Iwai wrote: > > > > @@ -761,6 +761,7 @@ struct snd_timer_params { > > > unsigned char reserved[60]; /* reserved */ > > > }; > > > > > > +#ifndef __KERNEL__ > > > struct snd_timer_status { > > > struct timespec tstamp; /* Timestamp - last update */ > > > unsigned int resolution; /* current period resolution in ns */ > > > > Do we need this ifndef? Is it for stopping the reference of struct > > snd_timer_status from the kernel code but only 32 and 64 variants? > > Well spotted, this is indeed a very recent change I did to the patch. > The idea here is to hide any use of 'time_t', 'timespec' and 'timeval' > from kernel compilation. These types are now defined in an incompatible > way by libc, so we have to remove them from the kernel's uapi headers. > I would prefer to remove them completely from the kernel (rather than > moving them from uapi to internal headers) to make it harder to write > y2038-incompatible code, and with the 90 patches I sent this week, > all users are gone from the kernel (this series was the last part). Could you put this trick in the changelog, too? > Interestingly, hiding snd_timer_status from the drivers /also/ caught > a but in a file when I had missed a reference that needed to be converted > to snd_timer_status64. Heh, that's no surprising, proving the usefulness :) thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel