From: Takashi Iwai <tiwai@suse.de>
To: Thorsten Glaser <t.glaser@tarent.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH] fix segfault on x32, 64-bit time_t-related format strings
Date: Fri, 22 Nov 2019 14:30:44 +0100 [thread overview]
Message-ID: <s5hmuco3unv.wl-tiwai@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1911211536340.23653@tglase-nb.lan.tarent.de>
On Thu, 21 Nov 2019 15:37:46 +0100,
Thorsten Glaser wrote:
>
> On Thu, 21 Nov 2019, Takashi Iwai wrote:
>
> > Could you split these changes to separate patches? They are for
> > different purposes.
>
> I’ve sent them as two separate patch files attachments.
Then please make them cleanly applicable via git-am, with a proper
subject, a proper changelog and your sign-off, etc.
At best send one patch per mail (and with a cover letter for multiple
patches).
> > Also, using time_t would be better if possible. Unfortunately a cast
> > is needed for printf usage, but other than that, time_t would leave us
> > the right size.
>
> In timediff() you mean? Hrm, indeed. I tried to be minimal-invasive
> at first.
I meant using time_t as much as possible instead of long long.
For printf(), there is no other option, but other calculations can be
replaced with time_t.
thanks,
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-11-22 13:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 20:28 [alsa-devel] [PATCH] fix segfault on x32, 64-bit time_t-related format strings Thorsten Glaser
2019-11-20 20:51 ` Thorsten Glaser
2019-11-21 8:11 ` Takashi Iwai
2019-11-21 14:37 ` Thorsten Glaser
2019-11-22 13:30 ` Takashi Iwai [this message]
[not found] ` <157133531799.6063.9249463816269134459.reportbug@tglase.lan.tarent.de>
2020-01-23 20:17 ` [alsa-devel] [PATCH 1/3] pcm: ensure amd64-specific asm code is not used on x32 mirabilos
2020-01-23 20:20 ` [alsa-devel] [PATCH 2/3] pcm: explicitly cast time types to types printf can handle mirabilos
2020-01-23 20:21 ` [alsa-devel] [PATCH 3/3] test: " mirabilos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hmuco3unv.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=t.glaser@tarent.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).