From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EF8DC433C1 for ; Wed, 24 Mar 2021 12:50:41 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88BF461A09 for ; Wed, 24 Mar 2021 12:50:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88BF461A09 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9FF1F1669; Wed, 24 Mar 2021 13:49:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9FF1F1669 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1616590237; bh=R4eIs0wFpI26KzAqq1t6TfCSqsfJ9U5adCyTJ0ZSo34=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ZEjnhRruSAHCY8zuHAwIDdhjQ96/fRL7rLoVE/S9FLGmnHptsdn19Yc200vRkzbbr UISGK11v+OkD2p5qzXIdwO2L8kRLSSZmhwdNkVjl7ShFGJZ0v4qpn12M1ItFLQ1mKm KLeC5KxqwPNX6rmQF90ed8HFBJXmg1rXTw0bhzR0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 07D86F80156; Wed, 24 Mar 2021 13:49:47 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 826B0F8016B; Wed, 24 Mar 2021 13:49:45 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 912EFF800FF for ; Wed, 24 Mar 2021 13:49:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 912EFF800FF X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0C421AD71; Wed, 24 Mar 2021 12:49:24 +0000 (UTC) Date: Wed, 24 Mar 2021 13:49:23 +0100 Message-ID: From: Takashi Iwai To: Ikjoon Jang Subject: Re: [PATCH] ALSA: usb-audio: Apply sample rate quirk to Logitech Connect In-Reply-To: References: <20210324105153.2322881-1-ikjn@chromium.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: alsa-devel@alsa-project.org, Dylan Robinson , open list , linux-usb@vger.kernel.org, Takashi Iwai , Joakim Tjernlund , Alexander Tsoy , Kai-Heng Feng , Greg Kroah-Hartman , Gregor Pintar , Olivia Mackintosh X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 24 Mar 2021 13:03:14 +0100, Ikjoon Jang wrote: > > On Wed, Mar 24, 2021, 7:16 PM Joakim Tjernlund > wrote: > > On Wed, 2021-03-24 at 18:51 +0800, Ikjoon Jang wrote: > > Logitech ConferenceCam Connect is a compound USB device with UVC and > > UAC. Not 100% reproducible but sometimes it keeps responding STALL to > > every control transfer once it receives get_freq request. > > > > This patch adds 046d:0x084c to a snd_usb_get_sample_rate_quirk list. > > > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=203419 > > Signed-off-by: Ikjoon Jang > > Most Logitech USB headset I got needs a delay in snd_usb_ctl_msg_quirk() > Have you tried to add say 20 ms delay in there? > > I didn't try that. But it sounds reasonable to me. > > let me try that quirk here. If that is the case, HID might need that delay > also. Logitech Group webcam had a similar problem on control xfer of > get_report from an another interface for HID. The Logitech devices with 046d:* should be covered generally in snd_usb_ctl_msg_quirk(), so I guess it's a different problem. But please check it first. > And 20ms can be too long if it's applied to every control transfer. I will > test the device with shorter delay if you didn't try it before. Actually the delay applied to Logitech devices is from 1 to 2ms, not 20ms. The 20ms delay is applied for some other devices. But if extending the delay fixes the problem, we need to reconsider the delay length. Takashi