From: Takashi Iwai <tiwai@suse.de>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: hda/hdmi: fix incorrect locking in hdmi_pcm_close
Date: Tue, 13 Oct 2020 18:34:22 +0200 [thread overview]
Message-ID: <s5hpn5mm6ep.wl-tiwai@suse.de> (raw)
In-Reply-To: <20201013152628.920764-1-kai.vehmanen@linux.intel.com>
On Tue, 13 Oct 2020 17:26:28 +0200,
Kai Vehmanen wrote:
>
> A race exists between closing a PCM and update of ELD data. In
> hdmi_pcm_close(), hinfo->nid value is modified without taking
> spec->pcm_lock. If this happens concurrently while processing an ELD
> update in hdmi_pcm_setup_pin(), converter assignment may be done
> incorrectly.
>
> This bug was found by hitting a WARN_ON in snd_hda_spdif_ctls_assign()
> in a HDMI receiver connection stress test:
>
> [2739.684569] WARNING: CPU: 5 PID: 2090 at sound/pci/hda/patch_hdmi.c:1898 check_non_pcm_per_cvt+0x41/0x50 [snd_hda_codec_hdmi]
> ...
> [2739.684707] Call Trace:
> [2739.684720] update_eld+0x121/0x5a0 [snd_hda_codec_hdmi]
> [2739.684736] hdmi_present_sense+0x21e/0x3b0 [snd_hda_codec_hdmi]
> [2739.684750] check_presence_and_report+0x81/0xd0 [snd_hda_codec_hdmi]
> [2739.684842] intel_audio_codec_enable+0x122/0x190 [i915]
>
> Fixes: 42b2987079ec ("ALSA: hda - hdmi playback without monitor in dynamic pcm bind mode")
> Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2020-10-13 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 15:26 [PATCH] ALSA: hda/hdmi: fix incorrect locking in hdmi_pcm_close Kai Vehmanen
2020-10-13 16:34 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hpn5mm6ep.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=kai.vehmanen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).