alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Kirill Tkhai <ktkhai@parallels.com>
Cc: tkhai@yandex.ru, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ak4117: Do not free priv until timer handler hasn't actually stopped using it
Date: Fri, 14 Feb 2014 14:17:18 +0100	[thread overview]
Message-ID: <s5hppmp25r5.wl%tiwai@suse.de> (raw)
In-Reply-To: <1392378477.5384.29.camel@tkhai>

At Fri, 14 Feb 2014 15:47:57 +0400,
Kirill Tkhai wrote:
> 
> Function del_timer() does not guarantee that timer was really deleted.
> If the timer handler is beeing executed at the moment, the function
> does nothing. So, it's possible to use already freed memory in the handler:
> 
> [ref: Documentation/DocBook/kernel-locking.tmpl]
> 
> This was found using grep and compile-tested only.

Thanks, applied.


Takashi

> 
> Signed-off-by: Kirill Tkhai <ktkhai@parallels.com>
> CC: Jaroslav Kysela <perex@perex.cz>
> CC: Takashi Iwai <tiwai@suse.de>
> ---
>  sound/i2c/other/ak4117.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/i2c/other/ak4117.c b/sound/i2c/other/ak4117.c
> index 40e33c9..88452e8 100644
> --- a/sound/i2c/other/ak4117.c
> +++ b/sound/i2c/other/ak4117.c
> @@ -62,7 +62,7 @@ static void reg_dump(struct ak4117 *ak4117)
>  
>  static void snd_ak4117_free(struct ak4117 *chip)
>  {
> -	del_timer(&chip->timer);
> +	del_timer_sync(&chip->timer);
>  	kfree(chip);
>  }
>  
> 
> 
> 

      reply	other threads:[~2014-02-14 13:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-14 11:47 [PATCH] ak4117: Do not free priv until timer handler hasn't actually stopped using it Kirill Tkhai
2014-02-14 13:17 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hppmp25r5.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=ktkhai@parallels.com \
    --cc=tkhai@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).