From: Takashi Iwai <tiwai@suse.de>
To: Mike Oliphant <oliphant@nostatic.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: Support for NUX MG-300 USB interface
Date: Mon, 18 Jan 2021 20:19:37 +0100 [thread overview]
Message-ID: <s5hr1migiie.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAHXb3bcFM0BswbuTe=6vP6JRd=TOf94Gu0FPAZmXT6634bCiAQ@mail.gmail.com>
On Mon, 18 Jan 2021 18:54:57 +0100,
Mike Oliphant wrote:
>
> Here is the dmesg output with dyndbg enabled. It looks like it is failing
> to find the clock source, and hence cannot obtain the valid sample rates.
>
> It looks like it is finding the clock selector (id: 40), but
> "uac_clock_selector_get_val()" is returning zero, and it never gets the
> clock source (id: 41).
Aha. Maybe the firmware doesn't expect it being asked as it's the
single connection.
Does the patch below help anything?
Takashi
--- a/sound/usb/clock.c
+++ b/sound/usb/clock.c
@@ -298,6 +298,11 @@ static int __uac_clock_find_source(struct snd_usb_audio *chip,
if (selector) {
int ret, i, cur;
+ if (selector->bNrInPins == 1) {
+ ret = 1;
+ goto find_source;
+ }
+
/* the entity ID we are looking for is a selector.
* find out what it currently selects */
ret = uac_clock_selector_get_val(chip, selector->bClockID);
@@ -314,6 +319,7 @@ static int __uac_clock_find_source(struct snd_usb_audio *chip,
return -EINVAL;
}
+ find_source:
cur = ret;
ret = __uac_clock_find_source(chip, fmt,
selector->baCSourceID[ret - 1],
next prev parent reply other threads:[~2021-01-18 19:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 18:56 Support for NUX MG-300 USB interface Mike Oliphant
2021-01-18 7:43 ` Takashi Iwai
2021-01-18 16:33 ` Mike Oliphant
2021-01-18 17:54 ` Mike Oliphant
2021-01-18 19:19 ` Takashi Iwai [this message]
2021-01-18 21:15 ` Mike Oliphant
2021-01-18 21:59 ` Takashi Iwai
2021-01-19 0:26 ` Mike Oliphant
2021-01-19 9:05 ` Takashi Iwai
2021-01-19 17:40 ` Mike Oliphant
2021-01-20 14:33 ` Takashi Iwai
2021-01-20 21:17 ` Mike Oliphant
2021-01-20 21:38 ` Takashi Iwai
2021-01-20 21:47 ` Mike Oliphant
2021-01-21 19:04 ` Mike Oliphant
2021-01-21 20:18 ` Mike Oliphant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hr1migiie.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=oliphant@nostatic.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).