From: Takashi Iwai <tiwai@suse.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ALSA: make snd_kcontrol_new name a normal string
Date: Mon, 26 Oct 2020 20:29:37 +0100 [thread overview]
Message-ID: <s5hsga03hwe.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAK8P3a2kdNuipus=_Jr=Scd5_E+68LDi4zxPLqrT05ffXzD7Xg@mail.gmail.com>
On Mon, 26 Oct 2020 20:03:39 +0100,
Arnd Bergmann wrote:
>
> On Mon, Oct 26, 2020 at 6:03 PM Takashi Iwai <tiwai@suse.de> wrote:
> > On Mon, 26 Oct 2020 17:52:18 +0100,
> > Arnd Bergmann wrote:
> > >
> > > From: Arnd Bergmann <arnd@arndb.de>
> > >
> > > When building with W=2, there are lots of warnings about the
> > > snd_kcontrol_new name field being an array of 'unsigned char'
> > > but initialized to a string:
> > >
> > > include/sound/soc.h:93:48: warning: pointer targets in initialization of 'const unsigned char *' from 'char *' differ in signedness [-Wpointer-sign]
> > >
> > > Make it a regular 'char *' to avoid flooding the build log with this.
> > >
> > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > I'm fine to apply this, but I thought we agreed to ignore pointer
> > signedness intentionally? There are lots of such places and we were
> > fed up in the past when gcc complained a lot about those...
>
> I'm only sending fixes for the ones in headers that get included in
> a lot of places. There are good reasons for building being able to
> build specific drivers or directories with W=2, but it's less helpful
> if there are many identical warnings.
OK, now I applied the patch. Thanks!
Takashi
prev parent reply other threads:[~2020-10-26 19:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 16:52 [PATCH] ALSA: make snd_kcontrol_new name a normal string Arnd Bergmann
2020-10-26 17:03 ` Takashi Iwai
2020-10-26 19:03 ` Arnd Bergmann
2020-10-26 19:29 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hsga03hwe.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@kernel.org \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).