alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
	LKML <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: [alsa-devel] [Regression drm-tip] Internal audio device missing
Date: Thu, 26 Dec 2019 16:45:02 +0100	[thread overview]
Message-ID: <s5htv5n5bwh.wl-tiwai@suse.de> (raw)
In-Reply-To: <91e1ebe8-270e-d62f-844e-2018fe77145e@molgen.mpg.de>

On Thu, 26 Dec 2019 15:41:34 +0100,
Paul Menzel wrote:
> 
> Dear Takashi,
> 
> 
> Am 26.12.19 um 11:03 schrieb Takashi Iwai:
> > On Thu, 26 Dec 2019 10:47:18 +0100, Paul Menzel wrote:
> 
> >> With
> >>
> >>      $ git describe --tags drm-tip/drm-tip
> >>      v5.5-rc3-1481-ga20d8cd6901a
> >>
> >> the internal audio device is not available, and just a dummy device.
> >>
> >> Running `alsa-info.sh` [1], the messages below are shown with the
> >> problematic Linux kernel.
> >>
> >>      alsactl: get_controls:567: snd_ctl_open error: Sound protocol is
> >> not compatible
> >>      cat: /tmp/alsa-info.ateDlDjrZX/alsactl.tmp: No such file or directory
> >
> > That's an unexpected side-effect of the recent protocol version bump
> > in sound.git for-next branch.  It seems that we can't change the minor
> > version unless we really want to break something.
> >
> > Below is the fix patch.  Please give it a try.
> 
> Thank you for the quick reply and fix.
> 
> > -- 8< --
> > From: Takashi Iwai <tiwai@suse.de>
> > Subject: [PATCH] ALSA: control: Fix incompatible protocol error
> >
> > The recent change to bump the ALSA control API protocol version from
> > 2.0.7 to 2.1.0 caused a regression on user-space; while the user-space
> > expects both the major and the minor versions to be identical with the
> > supported numbers, we changed the minor number from 0 to 1.
> >
> > For recovering from the incompatibility, this patch changes the
> > protocol version again to 2.0.8, which is compatible, but yet higher
> > than the original number 2.0.7, indicating that the protocol change.
> >
> > Fixes: bd3eb4e87eb3 ("ALSA: ctl: bump protocol version up to v2.1.0")
> > Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
> >   include/uapi/sound/asound.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h
> > index e36dadaf84ba..30ebb2a42983 100644
> > --- a/include/uapi/sound/asound.h
> > +++ b/include/uapi/sound/asound.h
> > @@ -936,7 +936,7 @@ struct snd_timer_tread {
> >    *                                                                          *
> >    ****************************************************************************/
> >   -#define SNDRV_CTL_VERSION		SNDRV_PROTOCOL_VERSION(2, 1,
> > 0)
> > +#define SNDRV_CTL_VERSION		SNDRV_PROTOCOL_VERSION(2, 0, 8)
> >     struct snd_ctl_card_info {
> >   	int card;			/* card number */
> >
> 
> Tested-by: Paul Menzel <pmenzel@molgen.mpg.de>
> 
> Are there CI systems, which should have caught this problem?
> 
> Which user-space component should forward this problem to the user
> (desktop environment displaying a warning)?

Unfortunately no -- I'd love to have it, though.
I usually test and push more carefully, but it was a bit rush before
the holidays :)

Now merged and pushed out.


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

      reply	other threads:[~2019-12-26 15:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-26  9:47 [alsa-devel] [Regression drm-tip] Internal audio device missing Paul Menzel
2019-12-26 10:03 ` Takashi Iwai
2019-12-26 14:41   ` Paul Menzel
2019-12-26 15:45     ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5htv5n5bwh.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmenzel@molgen.mpg.de \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).