From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: alsa-devel@alsa-project.org, Clemens Ladisch <clemens@ladisch.de>,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ALSA: firewire: Clean up a locking issue in copy_resp_to_buf()
Date: Fri, 13 Nov 2020 18:38:12 +0100 [thread overview]
Message-ID: <s5hv9e9dunv.wl-tiwai@suse.de> (raw)
In-Reply-To: <20201113101241.GB168908@mwanda>
On Fri, 13 Nov 2020 11:12:41 +0100,
Dan Carpenter wrote:
>
> The spin_lock/unlock_irq() functions cannot be nested. The problem is
> that presumably we would want the IRQs to be re-enabled on the second
> call the spin_unlock_irq() but instead it will be enabled at the first
> call so IRQs will be enabled earlier than expected.
>
> In this situation the copy_resp_to_buf() function is only called from
> one function and it is called with IRQs disabled. We can just use
> the regular spin_lock/unlock() functions.
>
> Fixes: 555e8a8f7f14 ("ALSA: fireworks: Add command/response functionality into hwdep interface")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Thanks, applied now with Cc to stable.
Takashi
prev parent reply other threads:[~2020-11-13 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 10:12 [PATCH] ALSA: firewire: Clean up a locking issue in copy_resp_to_buf() Dan Carpenter
2020-11-13 12:02 ` Takashi Sakamoto
2020-11-13 17:38 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hv9e9dunv.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).