From: Takashi Iwai <tiwai@suse.de>
To: Olivia Mackintosh <livvy@base.nu>
Cc: alsa-devel@alsa-project.org, Fabian Lesniak <fabian@lesniak-it.de>
Subject: Re: [PATCH v4 1/1] ALSA: usb-audio: Add DJM750 to Pioneer mixer quirk
Date: Fri, 05 Feb 2021 23:18:17 +0100 [thread overview]
Message-ID: <s5hwnvm17me.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210205184256.10201-2-livvy@base.nu>
On Fri, 05 Feb 2021 19:42:56 +0100,
Olivia Mackintosh wrote:
>
> This allows for N different devices to use the pioneer mixer quirk for
> setting capture/record type and recording level. The impementation has
> not changed much with the exception of an additional mask on
> private_value to allow storing of a device index:
> DEVICE MASK 0xff000000
> GROUP_MASK 0x00ff0000
> VALUE_MASK 0x0000ffff
>
> This could be improved by changing the arrays of wValues for each
> channel to contain named definitions (e.g. SND_DJM_CAP_LINE). It would
> improve readability and perhaps would allow using the same array for
> multiple channels. The channel number can be specified on the control
> next to the wIndex.
>
> Feedback is very much appreciated as I'm not the most proficient C
> programmer but am learning as I go.
>
> Signed-off-by: Olivia Mackintosh <livvy@base.nu>
Thanks, applied now.
Takashi
next prev parent reply other threads:[~2021-02-05 22:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 16:03 [PATCH] ALSA: usb-audio: Add DJM750 to Pioneer mixer quirk Olivia Mackintosh
2021-01-29 14:09 ` Fabian Lesniak
2021-01-29 15:13 ` Takashi Iwai
2021-01-29 15:21 ` Olivia Mackintosh
2021-02-01 15:34 ` František Kučera
2021-02-01 21:37 ` Fabian Lesniak
2021-02-02 1:08 ` Olivia Mackintosh
2021-02-04 3:44 ` [PATCH v2 0/2] Add DJM-750 and simplify Olivia Mackintosh
2021-02-04 7:03 ` Takashi Iwai
2021-02-04 19:39 ` [PATCH v3 0/1] " Olivia Mackintosh
2021-02-04 19:39 ` [PATCH v3 1/1] ALSA: usb-audio: Add DJM750 to Pioneer mixer quirk Olivia Mackintosh
2021-02-04 21:33 ` Takashi Iwai
2021-02-05 18:42 ` [PATCH v4 0/1] Add DJM-750 and simplify Olivia Mackintosh
2021-02-05 18:42 ` [PATCH v4 1/1] ALSA: usb-audio: Add DJM750 to Pioneer mixer quirk Olivia Mackintosh
2021-02-05 22:18 ` Takashi Iwai [this message]
2021-02-04 3:44 ` [PATCH v2 1/2] " Olivia Mackintosh
2021-02-04 3:44 ` [PATCH v2 2/2] ALSA: usb-audio: Simplify DJM mixer quirks Olivia Mackintosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwnvm17me.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=fabian@lesniak-it.de \
--cc=livvy@base.nu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).