From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7FE5C433E0 for ; Fri, 5 Feb 2021 22:19:23 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32B0364F9F for ; Fri, 5 Feb 2021 22:19:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32B0364F9F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DC3D11657; Fri, 5 Feb 2021 23:18:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DC3D11657 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1612563559; bh=o4JxAeomWAW56tG120XG/YznvdJJXyG3FHyW7yBJL6s=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=TLYWKvjTP2Z6zMBCiZuPKG9QLkcFHf7uBCULV4BvTeLYqmC4dwaTd9Jb4j+0/7z3f 2ofwjLEz+EZnfyVnCdYGUJlqRMId5R37fFguo8ZitreCPWrtCSQYKuga0wbeG5+Dbd G5uU03OxOYOnWnVIqAj3sUSJcypah8g8Y7mrrxvI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 64585F80156; Fri, 5 Feb 2021 23:18:29 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 20F39F8015A; Fri, 5 Feb 2021 23:18:28 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B35EEF800C0 for ; Fri, 5 Feb 2021 23:18:18 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B35EEF800C0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B38B2AEBD; Fri, 5 Feb 2021 22:18:17 +0000 (UTC) Date: Fri, 05 Feb 2021 23:18:17 +0100 Message-ID: From: Takashi Iwai To: Olivia Mackintosh Subject: Re: [PATCH v4 1/1] ALSA: usb-audio: Add DJM750 to Pioneer mixer quirk In-Reply-To: <20210205184256.10201-2-livvy@base.nu> References: <20210205184256.10201-1-livvy@base.nu> <20210205184256.10201-2-livvy@base.nu> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Fabian Lesniak X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 05 Feb 2021 19:42:56 +0100, Olivia Mackintosh wrote: > > This allows for N different devices to use the pioneer mixer quirk for > setting capture/record type and recording level. The impementation has > not changed much with the exception of an additional mask on > private_value to allow storing of a device index: > DEVICE MASK 0xff000000 > GROUP_MASK 0x00ff0000 > VALUE_MASK 0x0000ffff > > This could be improved by changing the arrays of wValues for each > channel to contain named definitions (e.g. SND_DJM_CAP_LINE). It would > improve readability and perhaps would allow using the same array for > multiple channels. The channel number can be specified on the control > next to the wIndex. > > Feedback is very much appreciated as I'm not the most proficient C > programmer but am learning as I go. > > Signed-off-by: Olivia Mackintosh Thanks, applied now. Takashi