From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43CCDC432C3 for ; Wed, 13 Nov 2019 17:15:23 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26416206DC for ; Wed, 13 Nov 2019 17:15:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="fEyKaxq9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26416206DC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 341991615; Wed, 13 Nov 2019 18:04:54 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 341991615 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1573664744; bh=C2Mi3K4xzHg/6POf2crnZHe3lPSxGluB8STfLUdbsw4=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=fEyKaxq9zQIzD1QUQRsI5mFc6OBFkrvi6/2StqvXPy6LtmOTk6ylls07CN2CWPNRy nbjrbw4QvkVfiDLlxNC+bjR/gf69U9jTPUDdRbUUsrRoIB/83q408EQwyzEsTIlh46 uL1jXubF9XZ4kRg1y2JSkIA/mC5mY1lRLbaMCvG4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 70EE8F80085; Wed, 13 Nov 2019 18:04:52 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6CE26F80086; Wed, 13 Nov 2019 18:04:50 +0100 (CET) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D4E38F80084 for ; Wed, 13 Nov 2019 18:04:46 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D4E38F80084 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id AB964B185; Wed, 13 Nov 2019 17:04:45 +0000 (UTC) Date: Wed, 13 Nov 2019 18:04:45 +0100 Message-ID: From: Takashi Iwai To: Arnd Bergmann In-Reply-To: References: <20191112151642.680072-1-arnd@arndb.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: ALSA Development Mailing List , y2038 Mailman List , "linux-kernel@vger.kernel.org" , Takashi Iwai , Mark Brown , Baolin Wang Subject: Re: [alsa-devel] [PATCH v6 0/8] Fix year 2038 issue for sound subsystem X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 13 Nov 2019 17:51:57 +0100, Arnd Bergmann wrote: > > On Wed, Nov 13, 2019 at 5:40 PM Takashi Iwai wrote: > > On Wed, 13 Nov 2019 15:32:44 +0100, Arnd Bergmann wrote: > > > > We had discussed alternatives for this one last time, and decided > > > to go with the solution I posted here. The main alternative would > > > be to change the 'timespec' in snd_timer_tread to a fixed-length > > > structure based on two 'long' members. This would avoid the > > > need to match the command with the time_t type, but the cost would > > > be requiring CLOCK_MONOTONIC timestamps to avoid the > > > overflow, and changing all application source code that requires > > > the type to be compatible with 'timespec'. > > > > Fair enough. > > > > One thing I forgot to mention: when we add/modify the ioctl or ABI, we > > need to increment the protocol version, e.g. SNDRV_PCM_VERSION to > > indicate user-space the supported ABI. Please change these in your > > next patches, too. > > Just to confirm: this should be a simple one-line patch at the end of the > series like > > diff --git a/tools/include/uapi/sound/asound.h > b/tools/include/uapi/sound/asound.h > index df1153cea0b7..72e8380c6dcd 100644 > --- a/include/uapi/sound/asound.h > +++ b/include/uapi/sound/asound.h > @@ -154,7 +154,7 @@ struct snd_hwdep_dsp_image { > * * > *****************************************************************************/ > > -#define SNDRV_PCM_VERSION SNDRV_PROTOCOL_VERSION(2, 0, 14) > +#define SNDRV_PCM_VERSION SNDRV_PROTOCOL_VERSION(2, 0, 15) > > typedef unsigned long snd_pcm_uframes_t; > typedef signed long snd_pcm_sframes_t; > > right? Most other kernel interfaces have no version numbering, so > I don't know what policy you have here. I don't mind much about that, so it's up to you -- we can fold this change into the patch that actually adds or modifies the ioctl, too. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel