From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: Simon Wood <simon@mungewell.org>,
alsa-devel@alsa-project.org, clemens@ladisch.de,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] ALSA: firewire-digi00x: exclude Avid Adrenaline from detection
Date: Sun, 23 Aug 2020 10:01:48 +0200 [thread overview]
Message-ID: <s5hzh6laiz7.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200823075545.56305-1-o-takashi@sakamocchi.jp>
On Sun, 23 Aug 2020 09:55:45 +0200,
Takashi Sakamoto wrote:
>
> Avid Adrenaline is reported that ALSA firewire-digi00x driver is bound to.
> However, as long as he investigated, the design of this model is hardly
> similar to the one of Digi 00x family. It's better to exclude the model
> from modalias of ALSA firewire-digi00x driver.
>
> This commit changes device entries so that the model is excluded.
>
> $ python3 crpp < ~/git/am-config-rom/misc/avid-adrenaline.img
> ROM header and bus information block
> -----------------------------------------------------------------
> 400 04203a9c bus_info_length 4, crc_length 32, crc 15004
> 404 31333934 bus_name "1394"
> 408 e064a002 irmc 1, cmc 1, isc 1, bmc 0, cyc_clk_acc 100, max_rec 10 (2048)
> 40c 00a07e01 company_id 00a07e |
> 410 00085257 device_id 0100085257 | EUI-64 00a07e0100085257
>
> root directory
> -----------------------------------------------------------------
> 414 0005d08c directory_length 5, crc 53388
> 418 0300a07e vendor
> 41c 8100000c --> descriptor leaf at 44c
> 420 0c008380 node capabilities
> 424 8d000002 --> eui-64 leaf at 42c
> 428 d1000004 --> unit directory at 438
>
> eui-64 leaf at 42c
> -----------------------------------------------------------------
> 42c 0002410f leaf_length 2, crc 16655
> 430 00a07e01 company_id 00a07e |
> 434 00085257 device_id 0100085257 | EUI-64 00a07e0100085257
>
> unit directory at 438
> -----------------------------------------------------------------
> 438 0004d6c9 directory_length 4, crc 54985
> 43c 1200a02d specifier id: 1394 TA
> 440 13014001 version: Vender Unique and AV/C
> 444 17000001 model
> 448 81000009 --> descriptor leaf at 46c
>
> descriptor leaf at 44c
> -----------------------------------------------------------------
> 44c 00077205 leaf_length 7, crc 29189
> 450 00000000 textual descriptor
> 454 00000000 minimal ASCII
> 458 41766964 "Avid"
> 45c 20546563 " Tec"
> 460 686e6f6c "hnol"
> 464 6f677900 "ogy"
> 468 00000000
>
> descriptor leaf at 46c
> -----------------------------------------------------------------
> 46c 000599a5 leaf_length 5, crc 39333
> 470 00000000 textual descriptor
> 474 00000000 minimal ASCII
> 478 41647265 "Adre"
> 47c 6e616c69 "nali"
> 480 6e650000 "ne"
>
> Reported-by: Simon Wood <simon@mungewell.org>
> Fixes: 9edf723fd858 ("ALSA: firewire-digi00x: add skeleton for Digi 002/003 family")
> Cc: <stable@vger.kernel.org> # 4.4+
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Thanks, applied.
Takashi
prev parent reply other threads:[~2020-08-23 8:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 7:55 [PATCH 2/2] ALSA: firewire-digi00x: exclude Avid Adrenaline from detection Takashi Sakamoto
2020-08-23 8:01 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hzh6laiz7.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=o-takashi@sakamocchi.jp \
--cc=simon@mungewell.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).