From: Takashi Iwai <tiwai@suse.de>
To: Hui Wang <hui.wang@canonical.com>
Cc: alsa-devel@alsa-project.org, stable@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ALSA: hda/hdmi - add a parameter to let users decide if checking the eld_valid
Date: Mon, 11 Nov 2019 17:04:27 +0100 [thread overview]
Message-ID: <s5hzhh2v1pw.wl-tiwai@suse.de> (raw)
In-Reply-To: <s5h7e46whpi.wl-tiwai@suse.de>
On Mon, 11 Nov 2019 16:33:45 +0100,
Takashi Iwai wrote:
>
> On Mon, 11 Nov 2019 15:45:02 +0100,
> Hui Wang wrote:
> >
> > With the commit 7f641e26a6df ("ALSA: hda/hdmi - Consider eld_valid
> > when reporting jack event"), the driver checks eld_valid before
> > reporting Jack state, this fixes the 4 HDMI/DP audio devices issue.
> >
> > But recently some users complained that the hdmi audio on their
> > machines couldn't work anymore with this commit. On their machines,
> > the monitor_present is 1 while the eld_valid is 0 when plugging a
> > monitor, and the hdmi audio could work even the eld_valid is 0.
> >
> > To make the hdmi audio work again on those machines, adding a module
> > parameter, if usrs want to skip the checking eld_valid, they
> > could set checking_eld_valid=0 when loading the module. And this
> > parameter only applies to sense_via_verbs, for those getting eld via
> > component, no need to apply this parameter since it is impossible
> > that present is 1 while eld_valid is 0.
> >
> > BugLink: https://bugs.launchpad.net/bugs/1834771
> > Fixes: 7f641e26a6df ("ALSA: hda/hdmi - Consider eld_valid when reporting jack event")
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Hui Wang <hui.wang@canonical.com>
>
> Well, this sort of module option is rather a last resort, so I
> hesitate to apply this.
>
> The bug reports in the above are a bit hard to digest quickly.
> Could you tell exactly which hardware (and drivers) show the problem?
>
> FWIW, amdgpu driver already got the audio-component binding recently,
> so this problem shouldn't be triggered, at least in this code path.
> And, for nouveau and radeon, I already submitted the patches to
> support the audio-component binding, but by some reason they haven't
> been merged to the upstream. In that case, we'd need to ping DRM
> guys.
On the second thought, I wonder whether eld_valid would be corrected
later by the graphics side at all. If yes, it's a timing issue, and
it can be corrected with the repolling.
A totally untested patch is below.
thanks,
Takashi
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -1549,19 +1549,25 @@ static bool hdmi_present_sense_via_verbs(struct hdmi_spec_per_pin *per_pin,
do_repoll = true;
}
- if (do_repoll)
+ do_repoll |= repoll && eld->eld_valid != eld->monitor_present;
+ if (do_repoll) {
schedule_delayed_work(&per_pin->work, msecs_to_jiffies(300));
- else
+ ret = false;
+ } else {
update_eld(codec, per_pin, eld);
-
- ret = !repoll || !eld->monitor_present || eld->eld_valid;
+ per_pin->repoll_count = 0;
+ ret = true;
+ }
jack = snd_hda_jack_tbl_get(codec, pin_nid);
if (jack) {
jack->block_report = !ret;
- jack->pin_sense = (eld->monitor_present && eld->eld_valid) ?
- AC_PINSENSE_PRESENCE : 0;
+ if (ret) {
+ jack->pin_sense = (eld->monitor_present && eld->eld_valid) ?
+ AC_PINSENSE_PRESENCE : 0;
+ }
}
+
mutex_unlock(&per_pin->lock);
return ret;
}
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-11-11 16:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 14:45 [alsa-devel] [PATCH] ALSA: hda/hdmi - add a parameter to let users decide if checking the eld_valid Hui Wang
2019-11-11 15:33 ` Takashi Iwai
2019-11-11 16:04 ` Takashi Iwai [this message]
2019-11-12 12:21 ` Hui Wang
2019-11-18 4:40 ` Hui Wang
2019-11-18 7:12 ` Takashi Iwai
2019-11-18 7:52 ` Hui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hzhh2v1pw.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=hui.wang@canonical.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).