From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E52AC4332B for ; Sat, 21 Mar 2020 10:45:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57A71206F9 for ; Sat, 21 Mar 2020 10:45:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57A71206F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 16AD66E323; Sat, 21 Mar 2020 10:45:31 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id 714EF6E2DC; Sat, 21 Mar 2020 08:40:14 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 88FF168AFE; Sat, 21 Mar 2020 09:40:12 +0100 (CET) Date: Sat, 21 Mar 2020 09:40:12 +0100 From: Christoph Hellwig To: Jason Gunthorpe Subject: Re: [PATCH hmm 4/6] mm/hmm: remove HMM_FAULT_SNAPSHOT Message-ID: <20200321084012.GD28695@lst.de> References: <20200320164905.21722-1-jgg@ziepe.ca> <20200320164905.21722-5-jgg@ziepe.ca> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200320164905.21722-5-jgg@ziepe.ca> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mailman-Approved-At: Sat, 21 Mar 2020 10:44:45 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Philip Yang , Ralph Campbell , John Hubbard , Felix.Kuehling@amd.com, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Jerome Glisse , Jason Gunthorpe , amd-gfx@lists.freedesktop.org, Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Fri, Mar 20, 2020 at 01:49:03PM -0300, Jason Gunthorpe wrote: > + struct hmm_range *range = hmm_vma_walk->range; > unsigned int required_fault = 0; > unsigned long i; > > - if (hmm_vma_walk->flags & HMM_FAULT_SNAPSHOT) > + /* > + * If there is no way for valid to be set in hmm_pte_need_fault() then > + * don't bother to call it. > + */ > + if (!(((range->flags[HMM_PFN_VALID] & range->pfn_flags_mask) | > + range->default_flags) & > + range->flags[HMM_PFN_VALID])) I think this needs to be split out into a well documented helper function, as it is pretty much unreadable all cramed into a complex conditional. _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx