From: Huang Rui <ray.huang@amd.com>
To: "Das, Nirmoy" <Nirmoy.Das@amd.com>
Cc: "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: fix the missing braces
Date: Thu, 26 Mar 2020 11:07:14 +0800 [thread overview]
Message-ID: <20200326030713.GB10282@jenkins-Celadon-RN> (raw)
In-Reply-To: <76a508ea-4138-ab14-e318-7c694e2f8583@amd.com>
On Wed, Mar 25, 2020 at 11:47:08PM +0800, Das, Nirmoy wrote:
> Hi Ray,
>
> I pushed a fix few minutes ago :)
>
No problem, that's fine. I should have looked at the mail list firstly.
Thanks,
Ray
>
> Regards,
>
> Nirmoy
>
> On 3/25/20 4:39 PM, Huang Rui wrote:
> > The braces are missed around amdgpu_ttm_training_reserve_vram_init().
> >
> > Signed-off-by: Huang Rui <ray.huang@amd.com>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> > index b397148..8afe62a 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> > @@ -1938,10 +1938,11 @@ int amdgpu_ttm_init(struct amdgpu_device *adev)
> > *The reserved vram for memory training must be pinned to the specified
> > *place on the VRAM, so reserve it early.
> > */
> > - if (!amdgpu_sriov_vf(adev))
> > + if (!amdgpu_sriov_vf(adev)) {
> > r = amdgpu_ttm_training_reserve_vram_init(adev);
> > if (r)
> > return r;
> > + }
> >
> > /* allocate memory as required for VGA
> > * This is used for VGA emulation and pre-OS scanout buffers to
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-03-26 3:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 15:39 [PATCH] drm/amdgpu: fix the missing braces Huang Rui
2020-03-25 15:47 ` Nirmoy
2020-03-26 3:07 ` Huang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326030713.GB10282@jenkins-Celadon-RN \
--to=ray.huang@amd.com \
--cc=Nirmoy.Das@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).