Re: [PATCH 12/15] drm/amdgpu/display: add a late register connector callback

From: Eric Biggers <ebiggers@kernel.org>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
	dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 12/15] drm/amdgpu/display: add a late register connector callback
Date: Tue, 7 Apr 2020 21:09:10 -0700	[thread overview]
Message-ID: <20200408040910.GA80793@sol.localdomain> (raw)
In-Reply-To: <20200207195058.2354-13-alexander.deucher@amd.com>

On Fri, Feb 07, 2020 at 02:50:55PM -0500, Alex Deucher wrote:
> To handle debugfs setup on non DP MST connectors.
> 
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
> Acked-by: Christian König <christian.koenig@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c  | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index af8155708569..b6190079ed3f 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -4486,6 +4486,19 @@ amdgpu_dm_connector_atomic_duplicate_state(struct drm_connector *connector)
>  	return &new_state->base;
>  }
>  
> +static int
> +amdgpu_dm_connector_late_register(struct drm_connector *connector)
> +{
> +	struct amdgpu_dm_connector *amdgpu_dm_connector =
> +		to_amdgpu_dm_connector(connector);
> +
> +#if defined(CONFIG_DEBUG_FS)
> +	connector_debugfs_init(amdgpu_dm_connector);
> +#endif
> +
> +	return 0;
> +}

This introduced a compiler warning:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function ‘amdgpu_dm_connector_late_register’:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4726:30: warning: unused variable ‘amdgpu_dm_connector’ [-Wunused-variable]
 4726 |  struct amdgpu_dm_connector *amdgpu_dm_connector =
      |                              ^~~~~~~~~~~~~~~~~~~

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx