AMD-GFX Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/1] drm/amdkfd: sparse: fix incorrect type in assignment
@ 2020-06-26 23:39 Felix Kuehling
  2020-07-06 17:45 ` Felix Kuehling
  0 siblings, 1 reply; 2+ messages in thread
From: Felix Kuehling @ 2020-06-26 23:39 UTC (permalink / raw)
  To: amd-gfx, amber.lin; +Cc: kernel test robot

The correct way to implement the fops->poll callback uses EPOLL* macros.

For reference see also:
commit a9a08845e9ac ("vfs: do bulk POLL* -> EPOLL* replacement")
commit 7a163b2195cd ("unify {de,}mangle_poll(), get rid of kernel-side POLL...")

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 73b753a11ae9 ("drm/amdkfd: Provide SMI events watch")
Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
---
 drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
index f3782627407f..7b348bf9df21 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
@@ -59,13 +59,14 @@ static const struct file_operations kfd_smi_ev_fops = {
 static __poll_t kfd_smi_ev_poll(struct file *filep,
 				struct poll_table_struct *wait)
 {
-	__poll_t mask;
 	struct kfd_smi_client *client = filep->private_data;
+	__poll_t mask = 0;
 
 	poll_wait(filep, &client->wait_queue, wait);
 
 	spin_lock(&client->lock);
-	mask = kfifo_is_empty(&client->fifo) ? 0 : POLLIN | POLLRDNORM;
+	if (!kfifo_is_empty(&client->fifo))
+		mask = EPOLLIN | EPOLLRDNORM;
 	spin_unlock(&client->lock);
 
 	return mask;
-- 
2.27.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] drm/amdkfd: sparse: fix incorrect type in assignment
  2020-06-26 23:39 [PATCH 1/1] drm/amdkfd: sparse: fix incorrect type in assignment Felix Kuehling
@ 2020-07-06 17:45 ` Felix Kuehling
  0 siblings, 0 replies; 2+ messages in thread
From: Felix Kuehling @ 2020-07-06 17:45 UTC (permalink / raw)
  To: amd-gfx, amber.lin

Ping.

Am 2020-06-26 um 7:39 p.m. schrieb Felix Kuehling:
> The correct way to implement the fops->poll callback uses EPOLL* macros.
>
> For reference see also:
> commit a9a08845e9ac ("vfs: do bulk POLL* -> EPOLL* replacement")
> commit 7a163b2195cd ("unify {de,}mangle_poll(), get rid of kernel-side POLL...")
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 73b753a11ae9 ("drm/amdkfd: Provide SMI events watch")
> Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> index f3782627407f..7b348bf9df21 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> @@ -59,13 +59,14 @@ static const struct file_operations kfd_smi_ev_fops = {
>  static __poll_t kfd_smi_ev_poll(struct file *filep,
>  				struct poll_table_struct *wait)
>  {
> -	__poll_t mask;
>  	struct kfd_smi_client *client = filep->private_data;
> +	__poll_t mask = 0;
>  
>  	poll_wait(filep, &client->wait_queue, wait);
>  
>  	spin_lock(&client->lock);
> -	mask = kfifo_is_empty(&client->fifo) ? 0 : POLLIN | POLLRDNORM;
> +	if (!kfifo_is_empty(&client->fifo))
> +		mask = EPOLLIN | EPOLLRDNORM;
>  	spin_unlock(&client->lock);
>  
>  	return mask;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-26 23:39 [PATCH 1/1] drm/amdkfd: sparse: fix incorrect type in assignment Felix Kuehling
2020-07-06 17:45 ` Felix Kuehling

AMD-GFX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/amd-gfx/0 amd-gfx/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 amd-gfx amd-gfx/ https://lore.kernel.org/amd-gfx \
		amd-gfx@lists.freedesktop.org
	public-inbox-index amd-gfx

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.freedesktop.lists.amd-gfx


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git